Skip to content

Commit

Permalink
Allow PMJSON 4.0 in podspec
Browse files Browse the repository at this point in the history
Bump Cartfile to 4.0 as well, since Carthage has no way to allow a range
greater than a single major version. This is a potentially breaking
change for Carthage users, but I'm not willing to bump PMHTTP's major
version because of Carthage limitations.
  • Loading branch information
lilyball committed Nov 15, 2019
1 parent 8f79bba commit d5846a1
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Cartfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
github "postmates/PMJSON" ~> 3.0
github "postmates/PMJSON" ~> 4.0
4 changes: 2 additions & 2 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
github "postmates/PMJSON" "v3.1.1"
github "robbiehanson/CocoaAsyncSocket" "ec6c373de9eb7606a229ab927d1cce432073cc26"
github "postmates/PMJSON" "v4.0.0"
github "robbiehanson/CocoaAsyncSocket" "b179ea4013e94e31e6e637955e520ea4fb9d1b13"
2 changes: 1 addition & 1 deletion PMHTTP.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ Pod::Spec.new do |s|
s.library = 'c++'
s.module_map = "Sources/pmhttp.modulemap"

s.dependency "PMJSON", "~> 3.0"
s.dependency "PMJSON", ">= 3.0", "< 5.0"
end
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,10 @@ work by you shall be dual licensed as above, without any additional terms or con

## Version History

#### Development

* Support PMJSON 4.x in addition to PMJSON 3.x with CocoaPods. Carthage doesn't support that kind of version range so it's now just set to PMJSON 4.x only.

#### v4.4.2 (2019-08-13)

* Fix a bug with the deprecated `HTTPManagerObjectParseRequest.credential` property where assigning to the property wouldn't work.
Expand Down

0 comments on commit d5846a1

Please sign in to comment.