Skip to content

fix: generate with strict mode #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025
Merged

Conversation

amaanq
Copy link
Contributor

@amaanq amaanq commented Oct 14, 2024

The grammar will fail to evaluate if JS is run in 'strict mode', since the variable assignments are assigning them as globals, which is disallowed in strict mode, and so the imports had to be updated as well.

@amaanq
Copy link
Contributor Author

amaanq commented Oct 24, 2024

No.

@postsolar postsolar merged commit 4cacfda into postsolar:main May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants