Add Unicode and escape sequence support#624
Draft
FrancoisLaferriere wants to merge 1 commit intopotassco:wip-20from
Draft
Add Unicode and escape sequence support#624FrancoisLaferriere wants to merge 1 commit intopotassco:wip-20from
FrancoisLaferriere wants to merge 1 commit intopotassco:wip-20from
Conversation
- Updated lexer to recognize \uXXXX, \t, and \r escape sequences in STRING and FLIT (f-strings) - Updated unquote() to parse \uXXXX and output UTF-8 - Updated PrintQuoted to output \r escape sequence - Removed unused quote() function - Added tests for escape sequences in strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #123
Changes
Added support for
\uXXXX,\t, and\rescape sequences in strings.\t,\r, and\uXXXXpatterns to STRING and FLIT (f-strings)\t,\r, and\uXXXXescapesquote()\rescape handlingQuestions
Should
\uXXXXbe converted to UTF-8 bytes in the internal representation (current behavior), or should it be preserved and printed back as\uXXXX? Currently:"caf\u00E9"→ internal UTF-8 → output"café"Currently, escape sequences in f-string literals are NOT processed, they pass through literally:
f"\n"outputs"\\n"Should we process escape sequences in f-string literals via
unquote(), or keep the current behavior where they are passed through literally?