-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch URLs from http to https #17
base: gh-pages
Are you sure you want to change the base?
Conversation
The web site is now available via https, let's switch the documentation to use it. Fixes potch#12
@potch - would you be willing to merge this soon? The CII Best Practices badge is discussing referring to unmaintained.tech, but suggesting the use of http instead of https could be a blocker for us. Thanks! |
Using a protocol-relative URL like |
@scy I'm not sure I understand your suggestion. Why would it be good to access the external resources using https a problem if the embedding website is accessible via http (and I assume https)? (Given current mainstream browsers where using http will be penalized, I'd say that's in general a bad idea?) |
There might be a good reason why the user is accessing the embedding website using plain HTTP, for example due to network restrictions, for performance reasons, or because their browser doesn't support HTTPS. In these cases, if you embed the badge always via HTTPS, it probably won't load. If, on the other hand, the embedding website is accessed via HTTPS, the badge will be loaded via HTTPS, too. There's no penalty. |
scy:
The "//" prefix does not work when referring to an external site, which in many cases is what's happening. The "//" prefix will only work if it's the same site. By contract, "https:" works everywhere (presuming your browser supports https, and if it doesn't, you shouldn't be accessing the public Internet with it). Also, if you use "//" and you started with "http:", you allow an attacker to intercept the data & replace it with anything. For many years, using https: was something special you only did on special sites. At this point, https:, is the norm, and using http: is just like using telnet - something you should avoid in most circumstances if the data might traverse the public Internet. |
I tried to imagine a use case of "cannot use HTTPS" in combination with this badge but didn't come up to one... I'd use the badge inserted in README.md files on Github-Repositories. Visiting Github repos (and displaying the rendered output of the file) happens via HTTPS anyway - so loading the badge via HTTPS will not be the problem I guess. |
The web site is now available via https, let's switch the documentation to use it.
Fixes #12