convert start.sh to powshell #298
Conversation
|
Warning Rate limit exceeded@xuweicheng has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 20 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis pull request adds a new PowerShell script ( Changes
Sequence Diagram(s)sequenceDiagram
participant S as start.ps1
participant D as Docker Compose
participant P as PostgreSQL
participant M as Alembic
participant V as Env/Deps Checker
participant F as FastAPI (Uvicorn)
participant C as Celery Worker
S->>S: Load .env variables
S->>D: Start Docker Compose
loop Check PostgreSQL readiness
S->>P: pg_isready check
P-->>S: Ready/Not Ready
end
S->>M: Apply database migrations
S->>V: Verify virtual environment & install dependencies
S->>M: Reapply migrations if needed
S->>F: Launch FastAPI application
S->>C: Start Celery worker
S->>S: Print success message
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (5)
README.md (1)
164-167: Enhance Windows-specific setup instructions.While you've added PowerShell execution instructions, Windows users will also need specific instructions for activating the virtual environment, which differs from the Unix command.
Consider adding these Windows-specific virtual environment activation instructions:
**Windows** ```powershell + # Create a virtual environment (if not already created) + python -m venv venv + + # Activate the virtual environment + .\venv\Scripts\Activate.ps1 + + # Install dependencies + pip install -r requirements.txt + ./start.ps1 ```start.ps1 (4)
49-51: Consider providing a way to terminate background processes.The FastAPI application is started as a background process with no easy way to terminate it.
# Start FastAPI application (using uvicorn instead of gunicorn for Windows compatibility) Write-Host "Starting momentum application..." -Start-Process -NoNewWindow powershell -ArgumentList "uvicorn app.main:app --host 0.0.0.0 --port 8001 --reload --log-level debug" +$uvicornProcess = Start-Process -NoNewWindow -PassThru powershell -ArgumentList "uvicorn app.main:app --host 0.0.0.0 --port 8001 --reload --log-level debug" +Write-Host "Started uvicorn with PID: $($uvicornProcess.Id)"Adding a comment at the end of the script to remind users how to stop the processes would also be helpful:
# To stop the background processes, you can run: # Stop-Process -Id [PID]
53-55: Capture Celery worker process ID for easier management.Similar to the FastAPI application, the Celery worker is started as a background process with no easy way to terminate it.
# Start Celery worker Write-Host "Starting Celery worker" -Start-Process -NoNewWindow powershell -ArgumentList "celery -A app.celery.celery_app worker --loglevel=debug -Q ${Env:CELERY_QUEUE_NAME}_process_repository -E --pool=solo" +$celeryProcess = Start-Process -NoNewWindow -PassThru powershell -ArgumentList "celery -A app.celery.celery_app worker --loglevel=debug -Q ${Env:CELERY_QUEUE_NAME}_process_repository -E --pool=solo" +Write-Host "Started Celery worker with PID: $($celeryProcess.Id)"
57-57: Add a PowerShell execution policy check.PowerShell has an execution policy that might prevent scripts from running. It would be helpful to check this and provide guidance.
+# Check PowerShell execution policy +$policy = Get-ExecutionPolicy +if ($policy -eq "Restricted") { + Write-Host "Warning: PowerShell execution policy is set to Restricted" + Write-Host "You may need to run: Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser" +} + Write-Host "All services started successfully!" +Write-Host "Press Ctrl+C to stop all services when done"
30-31: Clarify why migrations are applied twice.Migrations seem to be applied twice: once after PostgreSQL is ready (implied by the log message) and again after installing dependencies. This could be confusing.
The script has messages suggesting migrations are applied after Postgres is ready, but the actual migration command appears only at line 47. Consider revising the messaging or explaining the two-phase migration approach:
-Write-Host "Postgres is up - applying database migrations" +Write-Host "Postgres is up - continuing with setup"Alternatively, if you need to validate database connectivity before continuing:
-Write-Host "Postgres is up - applying database migrations" +Write-Host "Postgres is up - verifying database connectivity" +docker exec potpie_postgres psql -U postgres -c "SELECT 1" > $null +if ($LASTEXITCODE -ne 0) { + Write-Host "Error: Could not connect to Postgres database" + exit 1 +}
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
|
Thank you @xuweicheng ! |
|
@kinshuksinghbist please provide an update here after testing this |
Make the current code base run in windows powershell.
Summary by CodeRabbit
New Features
Documentation