Skip to content

Comments

THERMAL CAMERA LEPTON: Bin not there when installed with pip#83

Open
iezqrom wants to merge 6 commits intodevfrom
bin-not-pip
Open

THERMAL CAMERA LEPTON: Bin not there when installed with pip#83
iezqrom wants to merge 6 commits intodevfrom
bin-not-pip

Conversation

@iezqrom
Copy link
Collaborator

@iezqrom iezqrom commented Oct 30, 2025

I wasn’t sure how to flag this one. In the repository, the bin folder exists and contains the code required for the thermal camera to work on Windows. However, after installing the package with pip, the bin folder isn’t present.

My suspicion: This might be related to where the bin folder is located. It’s currently outside of the main package structure, so it may not be included when the library is built or uploaded to PyPI.

What I did:

  • Moved the bin folder inside poulet-py/.
  • Updated the code to reference the new path accordingly.

Open question: There might be something in the build or upload process of poulet-py that needs to be adjusted so the bin folder is packaged and installed properly. I might be missing a configuration detail here.

@iezqrom iezqrom requested a review from vkaramanis October 30, 2025 12:20
@vkaramanis
Copy link
Contributor

good catch.

there is a better way to include the folder in the pyproject.toml using either

[tool.hatch.build.targets.wheel.force-include]
"../bin" = "bin"

or

[tool.hatch.build.targets.wheel]
artifacts = [
  "bin/leptonUVC/x64/*.dll",
  "bin/leptonUVC/x64/*.xml
]

or both?
more info here

can you make this change?
maybe also to change the bin folder name to artifacts to have the same name convention with hatch?

…th in thermal_camera.py; remove obsolete binaries from x64 directory.
@iezqrom
Copy link
Collaborator Author

iezqrom commented Nov 24, 2025

I've implemented this, please review @vkaramanis

Copy link
Contributor

@vkaramanis vkaramanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to try putting this folder outside poulet_py, but mapping it in pyproject.toml, so to not blend it with internal code.
Can you try this, moving artifacts to root folder and see if it works?

@iezqrom
Copy link
Collaborator Author

iezqrom commented Nov 27, 2025

I meant to try putting this folder outside poulet_py, but mapping it in pyproject.toml, so to not blend it with internal code. Can you try this, moving artifacts to root folder and see if it works?

cool, i'll do next week too

@iezqrom
Copy link
Collaborator Author

iezqrom commented Dec 4, 2025

I meant to try putting this folder outside poulet_py, but mapping it in pyproject.toml, so to not blend it with internal code. Can you try this, moving artifacts to root folder and see if it works?

it's working! please check, i had to made a few adjustments to one function, but working now with artifacts outside

let me know if it's ready for dev

@vkaramanis

@iezqrom iezqrom changed the title Bin not there when installed with pip THERMAL CAMERA LEPTON: Bin not there when installed with pip Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants