Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding latex snippets(wip) #23

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

chhavi18387
Copy link

This is a work in progress pull request with reference to issue #10

@poush poush requested review from shashaBot and poush April 30, 2020 09:15
@shashaBot
Copy link
Collaborator

@chhavi18387 Thanks for the PR. Just go through ajaxorg/ace#3656 and quickly add the code for registering the snippets in our editor instance.

Copy link
Collaborator

@shashaBot shashaBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove README.md changes from this PR. A separate PR related to documentation would be a better place for these changes.

@chhavi18387
Copy link
Author

Yes @shashaBot but I actually happened to merge the documentation changes into the master branch of the forked repository. Could you please look into the documentation PR I've made and tell me if there's some scope for improvement? Also, I'd improve the local server setup instruction as @escher-m mentioned in issue #14 and I'll update you soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants