-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for named constants #86
Open
exussum12
wants to merge
17
commits into
povils:master
Choose a base branch
from
exussum12:fixMagicNamedNumbers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jan 28, 2019
-
Eg remove $six = 6 or $week = 7 These sorts of numbers are still magic, fixes povils#83
Configuration menu - View commit details
-
Copy full SHA for ebd6a7e - Browse repository at this point
Copy the full SHA ebd6a7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0862546 - Browse repository at this point
Copy the full SHA 0862546View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee2fa2c - Browse repository at this point
Copy the full SHA ee2fa2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 711f66f - Browse repository at this point
Copy the full SHA 711f66fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2553540 - Browse repository at this point
Copy the full SHA 2553540View commit details
Commits on Jan 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a98593b - Browse repository at this point
Copy the full SHA a98593bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 340a32b - Browse repository at this point
Copy the full SHA 340a32bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0072aa - Browse repository at this point
Copy the full SHA b0072aaView commit details
Commits on Mar 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e0b610f - Browse repository at this point
Copy the full SHA e0b610fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f1dff8 - Browse repository at this point
Copy the full SHA 8f1dff8View commit details
Commits on Mar 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9c676df - Browse repository at this point
Copy the full SHA 9c676dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bb6a9a - Browse repository at this point
Copy the full SHA 1bb6a9aView commit details
Commits on Apr 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 97d3287 - Browse repository at this point
Copy the full SHA 97d3287View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7895b80 - Browse repository at this point
Copy the full SHA 7895b80View commit details
Commits on Apr 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 88d529e - Browse repository at this point
Copy the full SHA 88d529eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 061317a - Browse repository at this point
Copy the full SHA 061317aView commit details
Commits on Apr 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a869472 - Browse repository at this point
Copy the full SHA a869472View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.