884: NFT batch transfer contract #2
Open
+2,300
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joze1239
changed the title
Contributor
Author
|
This is not needed anymore :D |
Contributor
Author
|
apparently, we need it again :D @sreckosmodis can you check this PR? |
|
|
||
|
|
||
| for (uint256 index; index < recipients.length; index++) { | ||
| ERC1155Base(contractAddress).safeTransferFrom(msg.sender, recipients[index], tokenIds[index], amounts[index], ""); |
Member
There was a problem hiding this comment.
Would it make sense to check the balance before the transfer?
So another require statement?
Get balance -> require to be more or equal to the amount
Contributor
Author
There was a problem hiding this comment.
yes, good point. I will add this
Member
There was a problem hiding this comment.
Now there is another point of view 😄
Do we prevent all the transfers just because one of the NFTs has insufficient balance?
If we do that we should at least add the tokenId to the error message 😄
Contributor
Author
There was a problem hiding this comment.
Reverted balance checking changes
sreckosmodis
approved these changes
Jan 31, 2022
sreckosmodis
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.