Enable ESLint in overcommit (#462)

.eslintignore

@@ -1 +1,2 @@
-node_modules/**
+node_modules/**
+fonts/**

.eslintrc.json

@@ -27,6 +27,9 @@
     "globals": {
     },
     "rules": {
+      "camelcase": [2, {
+        "ignoreDestructuring": false
+      }],
       "no-console": 1,
       "react/prop-types": 1,
       "react/forbid-prop-types": 2,
@@ -50,6 +53,7 @@
       "react/prefer-es6-class": 2,
       "react/self-closing-comp": 1,
       "react/sort-comp": 1,
-      "react/jsx-no-undef": [2, { "allowGlobals": true }]
+      "react/jsx-no-undef": [2, { "allowGlobals": true }],
+      "semi": [2, "never"]
     }
 }

.nvmrc

@@ -1 +1 @@
-8.9.4
+10.17.0

.overcommit.yml

@@ -11,11 +11,11 @@ PreCommit:
     problem_on_unmodified_line: ignore
     command: ['bundle', 'exec', 'rubocop']
   EsLint:
-    enabled: false
+    enabled: true
     on_warn: fail
     required_executable: 'yarn'
     problem_on_unmodified_line: ignore
-    command: ['yarn', 'lint', '--', '-f', 'compact']
+    command: ['yarn', 'lint', '-f', 'compact']
     include:
       - '.eslintrc'
       - 'app/pb_kits/playbook/**/*.js'

Dockerfile

@@ -6,8 +6,8 @@ RUN /pd_build/ruby_support/install_ruby_utils.sh
 RUN /pd_build/ruby_support/finalize.sh
 
 ENV NVM_VERSION v0.33.8
-ENV NODE_VERSION v8.9.4
-ENV NPM_VERSION 5.4.2
+ENV NODE_VERSION v10.17.0
+ENV NPM_VERSION 6.11.3
 ENV YARN_VERSION 1.13.0
 ENV NVM_DIR /home/app/.nvm
 ENV PATH $NVM_DIR/versions/node/$NODE_VERSION/bin:$PATH

package.json

@@ -27,11 +27,11 @@
   "homepage": "https://github.com/powerhome/playbook#readme",
   "devDependencies": {
     "@babel/preset-env": "^7.5.5",
-    "babel-eslint": "8.0.0",
+    "babel-eslint": "^10.0.3",
     "babel-preset-flow": "6.23.0",
     "clean-webpack-plugin": "^2.0.1",
-    "eslint-plugin-jsx-control-statements": "2.2.0",
-    "eslint-plugin-react": "7.3.0",
+    "eslint-plugin-jsx-control-statements": "^2.2.1",
+    "eslint-plugin-react": "^7.16.0",
     "extract-text-webpack-plugin": "3.0.0",
     "flow-bin": "0.54.1",
     "webpack-dev-server": "^3.7.2"
@@ -56,8 +56,8 @@
     "classnames": "^2.2.6",
     "css-modules-flow-types-loader": "0.3.1",
     "es5-shim": "4.5.9",
-    "eslint": "4.19.1",
-    "eslint-plugin-flowtype": "2.35.1",
+    "eslint": "^6.6.0",
+    "eslint-plugin-flowtype": "^4.4.1",
     "fast-sass-loader": "^1.5.0",
     "flow-bin": "0.54.1",
     "flow-runtime": "0.14.0",