js: Add missing method to PowertalkLMR (sent from EvaluationContext) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iglosiggio please rebase with current main so that we can try again. I had to change some weird thing with the CI and want to check if it works now. |
The #storeAssociation:value: message is sent by EvaluationContext and implemented on PowertalkRingRuntime. This commit adds it to PowertalkLMR too.
melkyades
force-pushed
the
fixup-lmr-association-setter
branch
from
96341c3
to
40ab1ef
Compare
|
ignore previous comment, github lets me push to you branch in your fork, interesting. I'll keep trying to fix the CI myself. |
melkyades
force-pushed
the
fixup-lmr-association-setter
branch
2 times, most recently
from
7bce29f
to
40ab1ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #storeAssociation:value: message is sent by
EvaluationContextand implemented onPowertalkRingRuntime.This PR adds it to
PowertalkLMRtoo.