Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MAINTAINERS.md #60

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update MAINTAINERS.md #60

wants to merge 3 commits into from

Conversation

TheMaskedTurtle
Copy link

@TheMaskedTurtle TheMaskedTurtle commented Sep 27, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Change list of maintainers for ws repositories

@TheMaskedTurtle
Update MAINTAINERS.md
7bb658f 
Signed-off-by: Joris Mancini <53527338+TheMaskedTurtle@users.noreply.github.com>
@TheMaskedTurtle
Update MAINTAINERS.md
c4f30e6 
Signed-off-by: Joris Mancini <53527338+TheMaskedTurtle@users.noreply.github.com>
So-Fras
So-Fras requested changes Oct 1, 2024
View reviewed changes
MAINTAINERS.md
**Reviewers:** [geofjamg](https://github.com/geofjamg), [jonenst](https://github.com/jonenst), [antoinebhs](https://github.com/antoinebhs)
**Committers:** [geofjamg](https://github.com/geofjamg), [jonenst](https://github.com/jonenst), [antoinebhs](https://github.com/antoinebhs)
**Reviewers:** [jonenst](https://github.com/jonenst), [antoinebhs](https://github.com/antoinebhs), [EtienneLt](https://github.com/EtienneLt), [SlimaneAmar](https://github.com/SlimaneAmar), [FranckLecuyer](https://github.com/FranckLecuyer)
**Committers:** [jonenst](https://github.com/jonenst), [antoinebhs](https://github.com/antoinebhs), [SlimaneAmar](https://github.com/SlimaneAmar), [FranckLecuyer](https://github.com/FranckLecuyer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to keep it to Jon and Antoine? They are already committers on other repos so we do not add more committers if we stick to them only.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided at project level that these four people are the new responsibles of the network-store topics as experts on the subject, we are all split in teams now in GridSuite so it would be easier if they could all be commiters

MAINTAINERS.md
This [repository](https://github.com/powsybl/powsybl-network-store-server) provides a client for the persistent implementation of the IIDM grid model.

**Reviewers:** [jonenst](https://github.com/jonenst), [antoinebhs](https://github.com/antoinebhs), [EtienneLt](https://github.com/EtienneLt), [SlimaneAmar](https://github.com/SlimaneAmar), [FranckLecuyer](https://github.com/FranckLecuyer)
**Committers:** [jonenst](https://github.com/jonenst), [antoinebhs](https://github.com/antoinebhs), [SlimaneAmar](https://github.com/SlimaneAmar), [FranckLecuyer](https://github.com/FranckLecuyer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark, do you need 2 new committers?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same answer

MAINTAINERS.md
**Reviewers:** [geofjamg](https://github.com/geofjamg), [jonenst](https://github.com/jonenst)
**Committers:** [geofjamg](https://github.com/geofjamg), [jonenst](https://github.com/jonenst)
**Reviewers:** [SlimaneAmar](https://github.com/SlimaneAmar), [antoinebhs](https://github.com/antoinebhs)
**Committers:** [SlimaneAmar](https://github.com/SlimaneAmar), [antoinebhs](https://github.com/antoinebhs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark as above. Could you justify the need to add a new committer?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The team in charge of the related topics in GridSuite project is the team B where Slimane is the tech lead and where Antoine can second him. Geoffroy and Jon are not specifically related to these topics anymore

MAINTAINERS.md Outdated
**Reviewers:** [flo-dup](https://github.com/flo-dup)
**Committers:** [flo-dup](https://github.com/flo-dup)
**Reviewers:** [SlimaneAmar](https://github.com/SlimaneAmar), [antoinebhs](https://github.com/antoinebhs)
**Committers:** [SlimaneAmar](https://github.com/SlimaneAmar), [antoinebhs](https://github.com/antoinebhs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark as above.

MAINTAINERS.md Outdated

### powsybl-diagram-viewer
This [repository](https://github.com/powsybl/powsybl-diagram-viewer) provides a service to display network-area digrams and single-line diagrams.

**Reviewers:** [flo-dup](https://github.com/flo-dup)
**Committers:** [flo-dup](https://github.com/flo-dup)
**Reviewers:** [SlimaneAmar](https://github.com/SlimaneAmar), [antoinebhs](https://github.com/antoinebhs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flo-dup should be left as a reviewer and a committer. He works on a regular basis with this repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I asked in my message in the channel but nobody answered ^^ I'll add him back

MAINTAINERS.md Outdated
**Reviewers:** [jonenst](https://github.com/jonenst)
**Committers:** [jonenst](https://github.com/jonenst)
**Reviewers:** [jonenst](https://github.com/jonenst), [TheMaskedTurtle](https://github.com/TheMaskedTurtle), [SlimaneAmar](https://github.com/SlimaneAmar), [etiennehomer](https://github.com/etiennehomer), [antoinebhs](https://github.com/antoinebhs), [EtienneLt](https://github.com/EtienneLt), [AbdelHedhili](https://github.com/AbdelHedhili), [FranckLecuyer](https://github.com/FranckLecuyer)
**Committers:** [jonenst](https://github.com/jonenst), [TheMaskedTurtle](https://github.com/TheMaskedTurtle), [SlimaneAmar](https://github.com/SlimaneAmar), [etiennehomer](https://github.com/etiennehomer), [antoinebhs](https://github.com/antoinebhs), [EtienneLt](https://github.com/EtienneLt), [AbdelHedhili](https://github.com/AbdelHedhili), [FranckLecuyer](https://github.com/FranckLecuyer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of people here! We should keep the number of committers to a minimum.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will reduce it

MAINTAINERS.md Outdated
This [repository](https://github.com/powsybl/powsybl-ws-dependencies) provides dependency versions for powsybl web services.

**Reviewers:** [jonenst](https://github.com/jonenst), [TheMaskedTurtle](https://github.com/TheMaskedTurtle), [SlimaneAmar](https://github.com/SlimaneAmar), [etiennehomer](https://github.com/etiennehomer), [antoinebhs](https://github.com/antoinebhs), [EtienneLt](https://github.com/EtienneLt), [AbdelHedhili](https://github.com/AbdelHedhili), [FranckLecuyer](https://github.com/FranckLecuyer)
**Committers:** [jonenst](https://github.com/jonenst), [TheMaskedTurtle](https://github.com/TheMaskedTurtle), [SlimaneAmar](https://github.com/SlimaneAmar), [etiennehomer](https://github.com/etiennehomer), [antoinebhs](https://github.com/antoinebhs), [EtienneLt](https://github.com/EtienneLt), [AbdelHedhili](https://github.com/AbdelHedhili), [FranckLecuyer](https://github.com/FranckLecuyer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark, this is really a lot. Is it necessary?

@TheMaskedTurtle
Update MAINTAINERS.md
9e0da50 
Signed-off-by: Joris Mancini <53527338+TheMaskedTurtle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@So-Fras So-Fras So-Fras requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheMaskedTurtle @So-Fras