Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote-service.md #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update remote-service.md #45

wants to merge 1 commit into from

Conversation

yasmas95
Copy link

No description provided.

Copy link
Contributor

@miovd miovd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use snake cases to match the names of the config properties of your class

@yasmas95
Copy link
Author

Ok It's done

@miovd miovd requested a review from mathbagu February 27, 2019 16:25
docs/configuration/modules/remote-service.md Outdated Show resolved Hide resolved
docs/configuration/modules/remote-service.md Outdated Show resolved Hide resolved
docs/configuration/modules/remote-service.md Outdated Show resolved Hide resolved
docs/configuration/modules/remote-service.md Outdated Show resolved Hide resolved
docs/configuration/modules/remote-service.md Outdated Show resolved Hide resolved
docs/configuration/modules/remote-service.md Outdated Show resolved Hide resolved
docs/configuration/modules/remote-service.md Outdated Show resolved Hide resolved
docs/configuration/modules/remote-service.md Outdated Show resolved Hide resolved
@miovd miovd self-requested a review February 28, 2019 16:57

## reconnection-initial-interval

The `reconnection-initial-interval` property is an optional property that defines the initial interval (in seconds) before the first reconnection. Its default values is 5.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*value
put back-ticks around the default value : *Its default value is 5

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok It's done


## reconnection-interval-mutiplier

The `reconnection-interval-mutiplier` property is an optional property that is used to increase the waiting interval between two reconnection attempts, for example if we wait 5 seconds for the first retry, we will then wait 5*reconnection-interval-mutiplier seconds before the second retry. Its default values is 2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*value
put back-ticks around the default value : *Its default value is 2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok It's done


## reconnection-max-interval

The `reconnection-max-interval` property is an optional property that that defines the max interval in seconds between two reconnections. Its default value is 3600.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put back-ticks around the default value : *Its default value is 3600

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok It's done


## reconnection-max

The `reconnection-max` property is an optional property that that defines the maximum times in seconds before abandoning the attempts to reconnect. Its default value is Integer.MAX_VALUE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put back-ticks around the default value : *Its default value is Integer.MAX_VALUE.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok It's done


The `reconnection-max-interval` property is an optional property that that defines the max interval in seconds between two reconnections. Its default value is 3600.
With the default parameters, there would be no reconnection attempt.
With autoreconnect-enabled set to true and the other parameters set to default values, in the case of a disconnection, the reconnection attempts would occur after 5", then 10", 20", 40", 1'20", 2'40" .... etc incresing until a maximum of one hour interval. after reconnection max intenal, the reconnection will be re-attempted every hour.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put back-ticks around default values and property names: *With autoreconnect-enabled set to true

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok It's done

@miovd miovd changed the title Update remote-service.md [WIP] Update remote-service.md Mar 22, 2019
@miovd miovd changed the title [WIP] Update remote-service.md Update remote-service.md Apr 8, 2019
Signed-off-by: MASSAOUDI YOUSSEF <youssef.massaoudi@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants