Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alliance Auth v4 compatibility update #158

Merged
merged 62 commits into from
Mar 15, 2024
Merged

Alliance Auth v4 compatibility update #158

merged 62 commits into from
Mar 15, 2024

Conversation

ppfeufer
Copy link
Owner

@ppfeufer ppfeufer commented Dec 27, 2023

Description

Added

  • Compatibility to Alliance Auth v4
    • Bootstrap 5
    • Django 4.2
  • Native lazy loading support for images

Changed

  • JS modernized
  • CSS modernizes
  • Templates changed to Bootstrap 5
  • Translations improved
  • General code cleanup and modernization

Removed

  • Compatibility to Alliance Auth v3

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #158 (bd6bdf5) into master (ecd3a0c) will decrease coverage by 0.21%.
The diff coverage is 46.67%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   53.26%   53.05%   -0.21%     
==========================================
  Files          22       21       -1     
  Lines        1228     1216      -12     
  Branches      102      100       -2     
==========================================
- Hits          654      645       -9     
+ Misses        565      562       -3     
  Partials        9        9              
Files Coverage Δ
aasrp/__init__.py 100.00% <100.00%> (ø)
aasrp/auth_hooks.py 100.00% <ø> (ø)
aasrp/helper/character.py 100.00% <ø> (+6.25%) ⬆️
aasrp/templatetags/aasrp.py 100.00% <100.00%> (ø)
aasrp/views/general.py 41.96% <100.00%> (ø)
aasrp/helper/eve_images.py 50.00% <0.00%> (ø)
aasrp/models.py 94.71% <50.00%> (+0.67%) ⬆️
aasrp/views/ajax.py 21.43% <33.34%> (+0.36%) ⬆️
aasrp/helper/icons.py 24.55% <0.00%> (-0.22%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd3a0c...bd6bdf5. Read the comment docs.

@ppfeufer ppfeufer force-pushed the allianceauth-v4 branch 3 times, most recently from 6281ec2 to 1dce710 Compare January 1, 2024 22:53
@ppfeufer ppfeufer changed the title Alliance Auth v4 compatibility Alliance Auth v4 compatibility update Feb 29, 2024
@ppfeufer ppfeufer marked this pull request as ready for review March 15, 2024 23:52
@ppfeufer ppfeufer merged commit 5e9e883 into master Mar 15, 2024
70 of 88 checks passed
@ppfeufer ppfeufer deleted the allianceauth-v4 branch March 15, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant