Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Kill mail detection from zKillboard's API response. #187

Merged
merged 1 commit into from
May 25, 2024

Conversation

ppfeufer
Copy link
Owner

Description

Fixed

  • Kill mail detection from zKillboard's API response.
    Under certain circumstances,
    the zKillboard API returns more than one kill mail in the response,
    which caused an error in the SRP request form.
    This has been fixed now. (Bug reported to zKillboard)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Under certain circumstances, the zKillboard API returns more than one kill mail in the response, which caused an error in the SRP request form.
This has been fixed now.
Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 52.66%. Comparing base (ed3c16e) to head (97bda19).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   53.05%   52.66%   -0.38%     
==========================================
  Files          21       21              
  Lines        1216     1225       +9     
  Branches      100      104       +4     
==========================================
  Hits          645      645              
- Misses        562      571       +9     
  Partials        9        9              
Files Coverage Δ
aasrp/views/general.py 41.55% <20.00%> (-0.40%) ⬇️
aasrp/managers.py 39.73% <11.12%> (-4.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3c16e...97bda19. Read the comment docs.

@ppfeufer ppfeufer marked this pull request as ready for review May 25, 2024 21:32
@ppfeufer ppfeufer merged commit c0ea273 into master May 25, 2024
86 of 88 checks passed
@ppfeufer ppfeufer deleted the investigating-zbk-bug branch May 25, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant