Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Optional settings for Discord Proxy (#240) #241

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ppfeufer
Copy link
Owner

@ppfeufer ppfeufer commented Dec 5, 2024

Description

Added

  • Optional settings for Discord Proxy. Comes in handy when used in a Docker environment.

Fixes #240

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Comes in handy when used in a Docker environment.
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.73%. Comparing base (55f3f07) to head (b0d6075).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
aasrp/discord/channel_message.py 33.34% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   52.62%   52.73%   +0.11%     
==========================================
  Files          21       21              
  Lines        1241     1246       +5     
  Branches       95       95              
==========================================
+ Hits          653      657       +4     
- Misses        581      582       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
aasrp/app_settings.py 66.67% <100.00%> (+12.13%) ⬆️
aasrp/discord/channel_message.py 27.50% <33.34%> (-0.70%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f3f07...b0d6075. Read the comment docs.

@ppfeufer ppfeufer merged commit c8dee81 into master Dec 5, 2024
44 checks passed
@ppfeufer ppfeufer deleted the discordproxy-config branch December 5, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No configuration option for discordproxy host and port
1 participant