Skip to content

Commit

Permalink
Test ActiveRecord 7.1, 7.2. and 8.0 and drop support for ancient vers…
Browse files Browse the repository at this point in the history
…ions.
  • Loading branch information
ppostma committed Nov 10, 2024
1 parent 1b87ba8 commit abbd8a3
Show file tree
Hide file tree
Showing 10 changed files with 89 additions and 105 deletions.
79 changes: 25 additions & 54 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,81 +9,52 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: [2.4, 2.5, 2.6, 2.7, 3.0, 3.1, 3.2]
ruby-version: [2.7, 3.0, 3.1, 3.2, 3.3]
gemfile:
- gemfiles/Gemfile.active_record-4.2
- gemfiles/Gemfile.active_record-5.0
- gemfiles/Gemfile.active_record-5.1
- gemfiles/Gemfile.active_record-5.2
- gemfiles/Gemfile.active_record-6.0
- gemfiles/Gemfile.active_record-6.1
- gemfiles/Gemfile.active_record-7.0
- gemfiles/Gemfile.active_record-7.1
- gemfiles/Gemfile.active_record-7.2
- gemfiles/Gemfile.active_record-8.0
- gemfiles/Gemfile.active_record-edge
exclude:
- ruby-version: 2.6
gemfile: gemfiles/Gemfile.active_record-4.2
- ruby-version: 2.7
gemfile: gemfiles/Gemfile.active_record-4.2
- ruby-version: 3.0
gemfile: gemfiles/Gemfile.active_record-4.2
- ruby-version: 3.1
gemfile: gemfiles/Gemfile.active_record-4.2
- ruby-version: 3.2
gemfile: gemfiles/Gemfile.active_record-4.2
- ruby-version: 2.6
gemfile: gemfiles/Gemfile.active_record-5.0
- ruby-version: 2.7
gemfile: gemfiles/Gemfile.active_record-5.0
- ruby-version: 3.0
gemfile: gemfiles/Gemfile.active_record-5.0
- ruby-version: 3.1
gemfile: gemfiles/Gemfile.active_record-5.0
- ruby-version: 3.2
gemfile: gemfiles/Gemfile.active_record-5.0
- ruby-version: 2.6
gemfile: gemfiles/Gemfile.active_record-5.1
- ruby-version: 2.7
gemfile: gemfiles/Gemfile.active_record-5.1
- ruby-version: 3.0
gemfile: gemfiles/Gemfile.active_record-5.1
- ruby-version: 3.1
gemfile: gemfiles/Gemfile.active_record-5.1
- ruby-version: 3.2
gemfile: gemfiles/Gemfile.active_record-5.1
- ruby-version: 2.7
gemfile: gemfiles/Gemfile.active_record-5.2
- ruby-version: 3.0
gemfile: gemfiles/Gemfile.active_record-5.2
- ruby-version: 3.1
gemfile: gemfiles/Gemfile.active_record-5.2
- ruby-version: 3.2
gemfile: gemfiles/Gemfile.active_record-5.2
- ruby-version: 2.4
gemfile: gemfiles/Gemfile.active_record-6.0
- ruby-version: 3.0
gemfile: gemfiles/Gemfile.active_record-6.0
- ruby-version: 3.1
gemfile: gemfiles/Gemfile.active_record-6.0
- ruby-version: 3.2
gemfile: gemfiles/Gemfile.active_record-6.0
- ruby-version: 2.4
- ruby-version: 3.3
gemfile: gemfiles/Gemfile.active_record-6.0
- ruby-version: 3.2
gemfile: gemfiles/Gemfile.active_record-6.1
- ruby-version: 2.4
gemfile: gemfiles/Gemfile.active_record-7.0
- ruby-version: 2.5
- ruby-version: 3.3
gemfile: gemfiles/Gemfile.active_record-6.1
- ruby-version: 3.2
gemfile: gemfiles/Gemfile.active_record-7.0
- ruby-version: 2.6
- ruby-version: 3.3
gemfile: gemfiles/Gemfile.active_record-7.0
- ruby-version: 2.4
- ruby-version: 2.7
gemfile: gemfiles/Gemfile.active_record-7.2
- ruby-version: 3.0
gemfile: gemfiles/Gemfile.active_record-7.2
- ruby-version: 2.7
gemfile: gemfiles/Gemfile.active_record-8.0
- ruby-version: 3.0
gemfile: gemfiles/Gemfile.active_record-8.0
- ruby-version: 3.1
gemfile: gemfiles/Gemfile.active_record-8.0
- ruby-version: 2.7
gemfile: gemfiles/Gemfile.active_record-edge
- ruby-version: 2.5
- ruby-version: 3.0
gemfile: gemfiles/Gemfile.active_record-edge
- ruby-version: 2.6
- ruby-version: 3.1
gemfile: gemfiles/Gemfile.active_record-edge
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ require:

AllCops:
NewCops: enable
TargetRubyVersion: 2.4
TargetRubyVersion: 2.7
DisplayCopNames: true
DisplayStyleGuide: true
Exclude:
Expand Down
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ source 'https://rubygems.org'
# Specify your gem's dependencies in smart_paginate.gemspec
gemspec

gem 'activerecord', '~> 7.0.4'
gem 'activerecord', '~> 8.0.0'

gem 'sqlite3', '~> 1.4'
gem 'sqlite3', '~> 2.0'
84 changes: 52 additions & 32 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,47 +2,64 @@ PATH
remote: .
specs:
smart_paginate (0.2.3)
activerecord (>= 4.2.0)
activerecord (>= 6.0.0)

GEM
remote: https://rubygems.org/
specs:
activemodel (7.0.4.1)
activesupport (= 7.0.4.1)
activerecord (7.0.4.1)
activemodel (= 7.0.4.1)
activesupport (= 7.0.4.1)
activesupport (7.0.4.1)
concurrent-ruby (~> 1.0, >= 1.0.2)
activemodel (8.0.0)
activesupport (= 8.0.0)
activerecord (8.0.0)
activemodel (= 8.0.0)
activesupport (= 8.0.0)
timeout (>= 0.4.0)
activesupport (8.0.0)
base64
benchmark (>= 0.3)
bigdecimal
concurrent-ruby (~> 1.0, >= 1.3.1)
connection_pool (>= 2.2.5)
drb
i18n (>= 1.6, < 2)
logger (>= 1.4.2)
minitest (>= 5.1)
tzinfo (~> 2.0)
securerandom (>= 0.3)
tzinfo (~> 2.0, >= 2.0.5)
uri (>= 0.13.1)
ast (2.4.2)
concurrent-ruby (1.2.2)
diff-lcs (1.5.0)
i18n (1.14.1)
base64 (0.2.0)
benchmark (0.4.0)
bigdecimal (3.1.8)
concurrent-ruby (1.3.4)
connection_pool (2.4.1)
diff-lcs (1.5.1)
drb (2.2.1)
i18n (1.14.6)
concurrent-ruby (~> 1.0)
minitest (5.17.0)
parallel (1.23.0)
parser (3.2.2.1)
logger (1.6.1)
minitest (5.25.1)
parallel (1.26.3)
parser (3.3.6.0)
ast (~> 2.4.1)
racc
racc (1.8.1)
rainbow (3.1.1)
rake (13.0.1)
regexp_parser (2.8.0)
rexml (3.2.5)
rake (13.2.1)
regexp_parser (2.9.2)
rexml (3.3.9)
rspec (3.12.0)
rspec-core (~> 3.12.0)
rspec-expectations (~> 3.12.0)
rspec-mocks (~> 3.12.0)
rspec-core (3.12.2)
rspec-core (3.12.3)
rspec-support (~> 3.12.0)
rspec-expectations (3.12.3)
rspec-expectations (3.12.4)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-mocks (3.12.5)
rspec-mocks (3.12.7)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-support (3.12.0)
rspec-support (3.12.2)
rubocop (1.12.1)
parallel (~> 1.10)
parser (>= 3.0.0.0)
Expand All @@ -52,9 +69,9 @@ GEM
rubocop-ast (>= 1.2.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.29.0)
parser (>= 3.2.1.0)
rubocop-performance (1.18.0)
rubocop-ast (1.34.1)
parser (>= 3.3.1.0)
rubocop-performance (1.19.1)
rubocop (>= 1.7.0, < 2.0)
rubocop-ast (>= 0.4.0)
rubocop-rake (0.6.0)
Expand All @@ -63,16 +80,19 @@ GEM
rubocop (~> 1.0)
rubocop-ast (>= 1.1.0)
ruby-progressbar (1.13.0)
sqlite3 (1.4.2)
tzinfo (2.0.5)
securerandom (0.3.1)
sqlite3 (2.2.0-x86_64-darwin)
timeout (0.4.2)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.4.2)
unicode-display_width (2.6.0)
uri (1.0.1)

PLATFORMS
ruby
x86_64-darwin-23

DEPENDENCIES
activerecord (~> 7.0.4)
activerecord (~> 8.0.0)
bundler (>= 1.12)
rake (~> 13.0)
rspec (~> 3.12.0)
Expand All @@ -81,7 +101,7 @@ DEPENDENCIES
rubocop-rake
rubocop-rspec
smart_paginate!
sqlite3 (~> 1.4)
sqlite3 (~> 2.0)

BUNDLED WITH
2.2.33
2.5.16
7 changes: 0 additions & 7 deletions gemfiles/Gemfile.active_record-5.2

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ source 'https://rubygems.org'
# Specify your gem's dependencies in smart_paginate.gemspec
gemspec path: '..'

gem 'activerecord', '~> 4.2.0'
gem 'sqlite3', '~> 1.3.13'
gem 'activerecord', '~> 7.1.0'
gem 'sqlite3', '~> 1.4.2'
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ source 'https://rubygems.org'
# Specify your gem's dependencies in smart_paginate.gemspec
gemspec path: '..'

gem 'activerecord', '~> 5.0.0'
gem 'sqlite3', '~> 1.3.13'
gem 'activerecord', '~> 7.2.0'
gem 'sqlite3', '~> 2.2.0'
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ source 'https://rubygems.org'
# Specify your gem's dependencies in smart_paginate.gemspec
gemspec path: '..'

gem 'activerecord', '~> 5.1.0'
gem 'sqlite3', '~> 1.3.13'
gem 'activerecord', '~> 8.0.0'
gem 'sqlite3', '~> 2.2.0'
2 changes: 1 addition & 1 deletion gemfiles/Gemfile.active_record-edge
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ source 'https://rubygems.org'
gemspec path: '..'

gem 'activerecord', git: 'https://github.com/rails/rails.git'
gem 'sqlite3', '~> 1.4.2'
gem 'sqlite3', '~> 2.2.0'
4 changes: 2 additions & 2 deletions smart_paginate.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

spec.required_ruby_version = '>= 2.4.0'
spec.required_ruby_version = '>= 2.7.0'

spec.add_development_dependency 'bundler', '>= 1.12'
spec.add_development_dependency 'rake', '~> 13.0'
Expand All @@ -32,5 +32,5 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rubocop-rake'
spec.add_development_dependency 'rubocop-rspec'

spec.add_dependency 'activerecord', '>= 4.2.0'
spec.add_dependency 'activerecord', '>= 6.0.0'
end

0 comments on commit abbd8a3

Please sign in to comment.