Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Solo] attributes getting committed by blocking from NUnit runs #6522

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Fix [Solo] attributes getting committed by blocking from NUnit runs #6522

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97485c5
Fix `[Solo]` attributes getting committed by blocking from NUnit runs
peppy Feb 7, 2025
7d88ff6
Remove unused using
bdach Feb 7, 2025
eaf9c29
Use `nameof()` instead of `typeof()`
bdach Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions osu.Framework/Testing/TestScene.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,10 @@ public override void BeforeTest(ITest test)
if (test.Fixture is not TestScene testScene)
return;

bool hasSoloAttribute = test.Method?.MethodInfo.CustomAttributes.Any(a => a.AttributeType == typeof(SoloAttribute)) == true;
if (DebugUtils.IsNUnitRunning && hasSoloAttribute)
throw new InvalidOperationException($"{typeof(SoloAttribute)} should not be specified on tests running under NUnit.");

// Since the host is created in OneTimeSetUp, all game threads will have the fixture's execution context
// This is undesirable since each test is run using those same threads, so we must make sure the execution context
// for the game threads refers to the current _test_ execution context for each test
Expand Down
Loading