Add support for deleting legacy replays and scores#363
Open
peppy wants to merge 1 commit intoppy:masterfrom
Open
Add support for deleting legacy replays and scores#363peppy wants to merge 1 commit intoppy:masterfrom
peppy wants to merge 1 commit intoppy:masterfrom
Conversation
bdach
reviewed
Mar 6, 2026
| DogStatsd.Increment("legacy_scores_deleted"); | ||
| var rulesetSpecifics = LegacyDatabaseHelper.GetRulesetSpecifics(score.ruleset_id); | ||
|
|
||
| await s3.DeleteObjectAsync(rulesetSpecifics.ReplayBucket, score.legacy_score_id.ToString(), cancellationToken); |
Collaborator
There was a problem hiding this comment.
Is not checking the result state of this intentional?
AWSSDK has a strange (for .NET land) API design where it will return failures wrapped in objects rather than do anything like throwing.
Comment on lines
+148
to
+151
| await s3.DeleteObjectAsync(rulesetSpecifics.ReplayBucket, score.legacy_score_id.ToString(), cancellationToken); | ||
|
|
||
| await db.ExecuteAsync($"DELETE FROM {rulesetSpecifics.ReplayTable} WHERE score_id = @scoreId", new { scoreId = score.legacy_score_id }); | ||
| await db.ExecuteAsync($"DELETE FROM {rulesetSpecifics.HighScoreTable} WHERE score_id = @scoreId", new { scoreId = score.legacy_score_id }); |
Collaborator
There was a problem hiding this comment.
Also this should all probably be guarded with !DryRun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs testing.