Support multiple file upload in single model #10703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
force-pushed
the
uploader-new
branch
4 times, most recently
from
211cdbf to
eae0cba
Compare
nanaya
force-pushed
the
uploader-new
branch
3 times, most recently
from
f267305 to
363e5c3
Compare
nanaya
force-pushed
the
uploader-new
branch
2 times, most recently
from
c2442ab to
e53fdd6
Compare
1 task
notbakaneko
requested changes
Dec 21, 2023
notbakaneko
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(technically already supported but creating new class for every single of them is rather silly)
Basically move the trait to its own class and standardise relevant attributes to single filename string.
I think the array was initially to allow additional attributes but then the later tables have it as table column instead so that's kind of pointless. There's also no need for it so far either 🤷
The image processing option is kind of questionable but should work for now 🕺