Skip to content

Expand Difficulty Increase mod articles #12629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 93 commits into from
Jun 16, 2025
Merged

Expand Difficulty Increase mod articles #12629

merged 93 commits into from
Jun 16, 2025

Conversation

Anax2i
Copy link
Contributor

@Anax2i Anax2i commented Jan 2, 2025

No description provided.

@TicClick TicClick self-requested a review January 27, 2025 14:45
Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more points:

  • could you retake customization menus screenshots and save them as PNGs?
  • please use period (.) as a decimal separator for clarity

@TicClick
Copy link
Contributor

TicClick commented Apr 7, 2025

yes -- please address my review that covers the articles themselves as well as specific wordings and phrasings

Anax2i and others added 21 commits April 8, 2025 18:24
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
Co-authored-by: TicClick <ya@ticclick.ch>
@Anax2i
Copy link
Contributor Author

Anax2i commented Apr 8, 2025

Done! @TicClick

@TicClick TicClick added the state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc. label Apr 17, 2025
@0x84f
Copy link
Contributor

0x84f commented Apr 17, 2025

talked to ticclick about this in the osu-wiki channel and partially on the previewer server, the images look really pixelated on smartphones, did you just change the image extension or did you re-take all of these?

image

also, i think the images look really janky on the wiki with the osu!(lazer) background (example), i would suggest removing the background so only the customisation window is visible (it'll make it look like it's floating which is IMO more aesthetically pleasing)

not sure how you are interfacing with the files but you should try and and stack these changes into one commit instead of posting commits for singular changes, check out pishi's guide

@TicClick TicClick removed the state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc. label Jun 16, 2025
Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in all fairness I didn't expect this to stall -- if odd-looking screenshots is the only reason this was put on hold, I think I can get over it

@TicClick TicClick merged commit 50c5cd6 into ppy:master Jun 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants