-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass osu!taiko "argon" skin #21153
Conversation
Is judgments visibility intended to be such? They are too transparent and quick, and barely noticeable with side vision, at least for me. |
You mean the "great" popup? You'd want it to last for longer? |
I've adjusted the location and tween of the hit results, should be a bit more visible now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reads okay
if (first.NewValue) | ||
{ | ||
InternalChild = new Circle | ||
{ | ||
Anchor = Anchor.Centre, | ||
Origin = Anchor.Centre, | ||
RelativeSizeAxes = Axes.Both | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could possibly also benefit from smarter pooling if we're pointing out stuff like #21072 (as in pool first ticks separately from the rest). Something for later I suppose.
CircularProgress
comes online withEdgeEffect
support. In theoryAlso
TickPiece
#21150