Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass osu!taiko "argon" skin #21153

Merged
merged 23 commits into from
Nov 12, 2022
Merged

First pass osu!taiko "argon" skin #21153

merged 23 commits into from
Nov 12, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Nov 7, 2022

  • Missing kiai flashes
  • Input drum is a bit.. "best effort". Will be able to improve this when the framework CircularProgress comes online with EdgeEffect support. In theory

Also

@Feodor0090
Copy link
Contributor

Is judgments visibility intended to be such? They are too transparent and quick, and barely noticeable with side vision, at least for me.

@peppy
Copy link
Member Author

peppy commented Nov 8, 2022

Is judgments visibility intended to be such? They are too transparent and quick, and barely noticeable with side vision, at least for me.

You mean the "great" popup? You'd want it to last for longer?

@peppy
Copy link
Member Author

peppy commented Nov 8, 2022

I've adjusted the location and tween of the hit results, should be a bit more visible now.

@bdach bdach self-requested a review November 11, 2022 18:06
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reads okay

Comment on lines +45 to +53
if (first.NewValue)
{
InternalChild = new Circle
{
Anchor = Anchor.Centre,
Origin = Anchor.Centre,
RelativeSizeAxes = Axes.Both
};
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could possibly also benefit from smarter pooling if we're pointing out stuff like #21072 (as in pool first ticks separately from the rest). Something for later I suppose.

@peppy peppy merged commit 3c9fbdb into ppy:master Nov 12, 2022
@peppy peppy deleted the argon-taiko branch November 15, 2022 05:32
@peppy peppy mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants