Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages #27920

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Upgrade packages #27920

wants to merge 6 commits into from

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Apr 18, 2024

Mainly for new realm version, but some others along the way.

Not 100% on the SignalR change with exceptions (have not tested yet). I'll test later today if no one beats me.

@smoogipoo
Copy link
Contributor

Do we know whether the underlying issue causing #27577 has been fixed by now? The realm-core issue is still open.

@peppy
Copy link
Sponsor Member Author

peppy commented Apr 18, 2024

Do we know whether the underlying issue causing #27577 has been fixed by now? The realm-core issue is still open.

Good call, we'll need to test for this before merging. Realm team says maybe.

@Joehuu Joehuu self-requested a review April 21, 2024 04:04
@Joehuu
Copy link
Member

Joehuu commented Apr 21, 2024

Unsure if the above is related, but on my Pixel 6a (Android 14), the game gets stuck on the splash screen, which seems to be the same issue as #27738 (the last Realm bump 2024.312.0). Tried 2024.312.0 and it had the same behavior, so nothing changed since.

The game doesn't crash and logcat doesn't seem to output anything helpful.

Also tried on Android 11 and 8 devices + discussion above had an Xperia 5 II (Android 10-12) and they don't have this problem, so it's maybe an Android 14 thing.

@peppy
Copy link
Sponsor Member Author

peppy commented Apr 21, 2024

@Joehuu are you able to pull logs from that?

@Joehuu
Copy link
Member

Joehuu commented Apr 21, 2024

Here's the log when I opened the app and waiting a minute:

logcat.txt

@peppy
Copy link
Sponsor Member Author

peppy commented Apr 22, 2024

Very concerning. Not much of anything useful in the logs as you say.

@bdach
Copy link
Collaborator

bdach commented Apr 22, 2024

Pushed merge conflict resolution & code quality fixes here.

Unsure if the above is related, but on my Pixel 6a (Android 14), the game gets stuck on the splash screen, which seems to be the same issue as #27738 (the last Realm bump 2024.312.0). Tried 2024.312.0 and it had the same behavior, so nothing changed since.
(...)
Also tried on Android 11 and 8 devices + discussion above had an Xperia 5 II (Android 10-12) and they don't have this problem, so it's maybe an Android 14 thing.

Cannot reproduce, game launches fine here. And I should be on android 14.

Screenshot_2024-04-22-09-40-15-30_fc704e6b13c4fb26bf5e411f75da84f2

Haven't tested at all besides that.

@Joehuu
Copy link
Member

Joehuu commented Apr 22, 2024

Good call, we'll need to test for this before merging. Realm team says maybe.

Tested and still getting the same error in example 2 of realm/realm-core#7454 using an exFAT external drive on Windows. Seemingly doesn't happen on macOS using the same drive.

@peppy
Copy link
Sponsor Member Author

peppy commented Apr 22, 2024

Thanks for testing, left a note in the realm issue thread.

@Joehuu
Copy link
Member

Joehuu commented May 1, 2024

Tested again on https://github.com/realm/realm-dotnet/releases/tag/12.1.0 and my two issues (Pixel 6a Android 14 and external exFAT on Windows) still happen.

@peppy
Copy link
Sponsor Member Author

peppy commented May 2, 2024

Yeah, unfortunately there's been no push to fix the issue yet 😢 .

@Joehuu
Copy link
Member

Joehuu commented Jul 20, 2024

The external exFAT on Windows issue seems to be fixed in https://github.com/realm/realm-dotnet/releases/tag/12.3.0, but Android 14 on my Pixel 6a still has the same issue.

@peppy
Copy link
Sponsor Member Author

peppy commented Jul 20, 2024

@Joehuu has the android issue been reported to realm's end yet? are you 100% sure it's realm related?

@Joehuu
Copy link
Member

Joehuu commented Jul 20, 2024

Not that I know of, no. I'm sure it's realm as just changing realm versions triggers the Android 14 on Pixel issue. It started since https://github.com/realm/realm-dotnet/releases/tag/11.6.1.

Just to see if the external exFAT on Windows issue is related, it is not. That started in https://github.com/realm/realm-dotnet/releases/tag/11.7.0 but as I said, it's fixed in the latest release.

@frenzibyte
Copy link
Member

We...probably should report it to Realm then?

@Joehuu
Copy link
Member

Joehuu commented Jul 26, 2024

Found the issue, maybe: realm/realm-core#7950

@bdach
Copy link
Collaborator

bdach commented Oct 10, 2024

Heads up that I might have a possible route forward; see realm/realm-core#7950 (comment). If realm ends up being fully dead (core and sdks) and we end up forking, maybe adopting that cmake patch is going to make things sorta-kinda work for us at least...?

@Joehuu would you be able to test this on device to confirm? You can grab nuget packages with the fix from the artifact listing at https://github.com/bdach/realm-dotnet/actions/runs/11255982167.

@Joehuu
Copy link
Member

Joehuu commented Oct 10, 2024

Works fine. Did some recommended beatmap downloading and playing/completing a beatmap with no problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants