Use proportion of difficult sliders to better estimate sliderbreaks on classic accuracy scores #31234
+65
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsunyoku
requested changes
Jan 7, 2025
tsunyoku
previously approved these changes
Jan 9, 2025
stanriders
requested changes
Jan 9, 2025
| return 0; | ||
|
|
||
| // Use a weighted sum of all strains. Constants are arbitrary and give nice values | ||
| return SliderStrains.Sum(s => 1.1 / (1 + Math.Exp(-10 * (s / consistentTopStrain - 0.88)))); |
There was a problem hiding this comment.
Use DifficultyCalculationUtils.Logistic
There was a problem hiding this comment.
We should change this for the other places too (separate PR)
There was a problem hiding this comment.
I'm pretty sure I already did in most places
| { | ||
| sliderStrains.Add(currentStrain); | ||
| } | ||
| SliderStrains.Add(currentStrain); | ||
|
|
||
| return currentStrain; | ||
| } | ||
|
|
||
| public double GetDifficultSliders() |
There was a problem hiding this comment.
Can't we combine this with CountTopWeightedSliders? They're doing essentially the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works out individual top weighted strain count for hitcircles and sliders, and then multiplies countmiss by 1 + the proportion of top weighted strain on sliders to account for misses on sliders sliderbreaks. This assumes that the player breaks equally on difficult hitcircles and sliders, which is the most fair assumption in my opinion.
The number of sliderbreaks is then scaled with combo, to account for the fact that higher combo scores have less places for sliderbreaks to hide in.
Spinners are handled incorrectly (they're included in the hitcircle strain count) but because spinners are 0 difficulty anyways there is negligible values impact, so making a better solution would probably be more effort than it's worth.
TopWeightedSliderFactormay be infinity on maps with no circles. This doesn't have any adverse values effects, becauseestimatedSliderbreaksis capped atcountMeh + countOk, but I'm unsure if it's going to cause any other weirdness.This probably wants some form of miss penalty or
effectiveMissCountadjustment, because currently every affected score is losing.Sliderbreaks may be double dipped, as it uses
effectiveMisscount + estimatedSliderbreaks, whileeffectiveMissCountmay already contain some estimated sliderbreaks. I'm not really sure of a good way to resolve this, and a little doubtful that resolving it would have any significant effect.