Move all score-independent bonuses into star rating #31351
+169
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with everything but length bonus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC.
Moves all PP calculation bonuses that don't require score information into star rating for the osu! ruleset. Star rating and PP intentionally have a direct relationship with eachother, and this is enriching that. This won't make any difference to PP values, but this will allow for star rating to have a tighter relation to PP by including difficulty-related factors such as length bonus, AR bonus etc.
I think this makes the most sense given these bonuses exist to award for being difficult independently of the individual score which is exactly what difficulty calculation/star rating is for.
Star rating is slightly downscaled (a new constant is created as a result) to factor for most maps gaining a lot of SR on average by the various bonuses.