Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/converters/src/__tests__/validation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,27 @@ You are a test agent.
expect(result.valid).toBe(true);
expect(result.errors).toHaveLength(0);
});

it('should include property name in additionalProperties error', () => {
const invalidClaude = `---
name: test-agent
description: "Test agent"
allowed-tools: Read, Write, Bash
---

# Test Agent

You are a test agent.
`;

const result = validateMarkdown('claude', invalidClaude, 'agent');
expect(result.valid).toBe(false);
expect(result.errors.length).toBeGreaterThan(0);
// The error should include the invalid property name
const errorMessage = result.errors[0].message;
expect(errorMessage).toContain('allowed-tools');
expect(errorMessage).toContain('must NOT have additional properties');
});
});

describe('validateFormat', () => {
Expand Down
16 changes: 14 additions & 2 deletions packages/converters/src/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,20 @@ export function validateFormat(

if (!valid && validate.errors) {
for (const error of validate.errors) {
const path = error.instancePath || '/' + (error.params as { missingProperty?: string }).missingProperty || '/';
const message = error.message || 'Validation error';
const params = error.params as {
missingProperty?: string;
additionalProperty?: string;
allowedValues?: unknown[];
};
const path = error.instancePath || '/' + (params.missingProperty || '');
let message = error.message || 'Validation error';

// Enhance error messages with additional context
if (error.keyword === 'additionalProperties' && params.additionalProperty) {
message = `${message}: '${params.additionalProperty}'`;
} else if (error.keyword === 'enum' && params.allowedValues) {
message = `${message}. Allowed values: ${params.allowedValues.join(', ')}`;
}

// Categorize as error or warning based on severity
const validationError: ValidationError = {
Expand Down
Loading