Refactor BLE Menu Options and Reposition "Press to Act" Display in WiFi Information

[9dl]

Proposed Changes

Streamlined the BLE menu options for better usability and adjusted the "Press to Act" display position to improve UI clarity and alignment.

Types of Changes

• Refactor
• UI/UX Enhancement

Verification

The changes can be verified by:

1. Navigating to the BLE menu.
2. Ensuring the options are streamlined and no longer redundant. (in code)
3. Checking that the "Press to Act" text is correctly positioned as intended.

Testing

Manual testing was conducted to verify:

• The BLE menu displays the updated options without like before and works.
• The "Press to Act" text is in its new position across only on CYD.

Linked Issues

NONE

User-Facing Change

The BLE menu options are now more streamlined, and the "Press to Act" text has been repositioned for better readability (was bugged out for CYD).

Further Comments

Small refactor nothing big 😄

[9dl]

Before:

After:

[bmorcelli]

I fixed the message on screen here

Bruce/src/modules/wifi/wifi_atks.cpp

Line 85 in e179ed3

tft.drawString("Press " + String(BTN_ALIAS) + " to act", 10, HEIGHT - 20);

BLE will be reworked, so I will leave it as it is for now, so I won't merge this PR

Thank you for your contribution

[9dl]

Hi @bmorcelli,

Thank you for your feedback! I see that you’ve chosen a simpler fix with the line:

tft.drawString("Press " + String(BTN_ALIAS) + " to act", 10, HEIGHT - 20);

While this works, I wanted to explain why I proposed using the #if !defined(HAS_TOUCH) approach in my fix. By incorporating the conditional preprocessor directive, my solution allows for device-specific customization, which ensures that the display behavior can be adapted based on the presence of a touch interface. This would be beneficial in cases where different devices may need different handling without modifying the core logic.

Additionally, I also refactored some of the BLE code, aiming for better maintainability and scalability. I’d love to hear your thoughts on this approach and whether you think it could be improved further.

If you believe the #if !defined(HAS_TOUCH) condition might not be suitable or if there are concerns I’m not considering, I’d really appreciate your insights.

Thanks again for your time and for reviewing my PR!

[bmorcelli]

Touch screen devices have HEIGHT set with HEIGHT=tft.getHeight() - 20; but is is set in the platformio.ini.. so we keep screen drawing equal to all devices.. so we try to no have behavior for different devices

I understand your idea for BLE code, and it is a good thing.. but it is to be reworked as soon as I finish the last touches in the Launcher.. I need to rework it to stop the restartings

[9dl]

Okay, thank you for the clarification! 😄