Release 1.0.1 (#15)

* Remove trailing commas task string (#11)

removed trailing commas from Task#String()

* validated prom endpoint + updated test code. (#13)

validated prom endpoint + updated test code.

WithPrometheusEndpoint(...) Option also validates the endpoint.
This ensures that the datafetcher has a valid endpoint to work with.

Updated workflow to now test with docker-compose installation

* Badges (#14)

added badges for godoc and workflow status

.github/workflows/workflow.yml

@@ -1,4 +1,4 @@
-name: Task-Ranker
+name: Build and Test
 
 on:
   push:
@@ -34,4 +34,8 @@ jobs:
       run: go build -v .
 
     - name: Test
-      run: go test -v ./...
+      run: |
+        ./create_test_env
+        sleep 3s
+        go test -v ./...
+        ./tear_down_test_env

README.md

@@ -1,4 +1,7 @@
-# Task Ranker
+# Task Ranker 
+[![GoDoc](https://godoc.org/github.com/pradykaushik/task-ranker?status.svg)](https://godoc.org/github.com/pradykaushik/task-ranker)
+![Build](https://github.com/pradykaushik/task-ranker/workflows/Build%20and%20Test/badge.svg)
+
 Rank tasks running as docker containers in a cluster.
 
 Task Ranker runs as a cron job on a specified schedule. Each time the task ranker is run,

datafetcher/prometheus/dataFetcher.go

@@ -23,6 +23,7 @@ import (
 	"github.com/prometheus/client_golang/api"
 	"github.com/prometheus/client_golang/api/prometheus/v1"
 	"github.com/prometheus/common/model"
+	"net/http"
 	"time"
 )
 
@@ -59,6 +60,11 @@ func WithPrometheusEndpoint(endpoint string) Option {
 		if endpoint == "" {
 			return errors.New("invalid endpoint")
 		}
+		// Validating the prometheus endpoint.
+		_, err := http.Get(endpoint + "/metrics")
+		if err != nil {
+			return errors.Wrap(err, "invalid endpoint for prometheus server")
+		}
 		f.endpoint = endpoint
 		return nil
 	}

entities/task.go

@@ -75,11 +75,5 @@ func (t Task) GetHostname() string {
 }
 
 func (t Task) String() string {
-	var buf bytes.Buffer
-	buf.WriteString("[")
-	buf.WriteString(fmt.Sprintf("TaskID = %s,", t.ID))
-	buf.WriteString(fmt.Sprintf("Hostname = %s,", t.Hostname))
-	buf.WriteString(fmt.Sprintf("Weight = %f,", t.Weight))
-	buf.WriteString("]")
-	return buf.String()
+	return fmt.Sprintf("[TaskID = %s, Hostname = %s, Weight = %f]", t.ID, t.Hostname, t.Weight)
 }

ranker_e2e_test.go

@@ -42,6 +42,9 @@ func initTaskRanker(strategy string) (*TaskRanker, error) {
 
 	prometheusDataFetcher, err = prometheus.NewDataFetcher(
 		prometheus.WithPrometheusEndpoint("http://localhost:9090"))
+	if err != nil {
+		return nil, err
+	}
 
 	dummyReceiver = new(dummyTaskRanksReceiver)
 	tRanker, err = New(