This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
Allow specifying multiple Marathon addresses and failover to each sequentially #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequentially when making requests * This is what the Python Marathon API client does
Current coverage is 99.75% (diff: 100%)@@ develop #74 diff @@
==========================================
Files 17 18 +1
Lines 1570 1664 +94
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1566 1660 +94
Misses 4 4
Partials 0 0
|
jerith
reviewed
Nov 23, 2016
| @@ -532,7 +605,7 @@ def test_get_json_field(self): | |||
|
|
|||
| request = yield self.requests.get() | |||
| self.assertThat(request, HasRequestProperties( | |||
| method='GET', url=self.uri('/my-path'))) | |||
| method='GET', url='http://localhost:8080/my-path')) | |||
There was a problem hiding this comment.
Can we make self.uri() work for the common case instead of having to explicitly provide the full URI everywhere?
| usage: marathon-acme [-h] [-a ACME] [-m MARATHON] [-l LB [LB ...]] [-g GROUP] | ||
| [--listen LISTEN] | ||
| usage: marathon-acme [-h] [-a ACME] [-m MARATHON [MARATHON ...]] | ||
| [-l LB [LB ...]] [-g GROUP] [--listen LISTEN] |
There was a problem hiding this comment.
I'm not a huge fan of space-separated opts like -m foo bar baz, because it looks like the extras are positional args.
Can we make these comma-separated or something?
There was a problem hiding this comment.
Can I maybe do this in a separate PR and do it for --lb as well?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48.
I basically copied what the "official" Marathon Python client does but in async.