Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to check that research consent is undefined #626

Merged
merged 3 commits into from
Nov 8, 2023
Merged

add test to check that research consent is undefined #626

merged 3 commits into from
Nov 8, 2023

Conversation

Hlamallama
Copy link
Contributor

No description provided.

erikh360
erikh360 reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@erikh360 erikh360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll also want to test that the payload after the check is correct because isn't that where the code changed?

@Hlamallama Hlamallama merged commit bd496cc into develop Nov 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikh360 erikh360 erikh360 left review comments

@Buhle79 Buhle79 Buhle79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hlamallama @erikh360 @Buhle79