This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
ASR-14: accept full okta domains #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er subdomain, we now truncate and accept the subdomain
dkaman
suggested changes
Oct 19, 2020
| @@ -62,6 +63,16 @@ func (Driver) New(opts map[string]string) (nozzle.Nozzle, error) { | |||
| return nil, fmt.Errorf("okta nozzle requires 'subdomain' config parameter") | |||
| } | |||
|
|
|||
| // check if operator entered full domain instead of subdomain | |||
| if strings.Contains(subdomain, ".okta.com") { | |||
There was a problem hiding this comment.
This check may not work if the domain has .okta.com in the middle of it. We have a function in the Util package util.ValidateURLSuffix designed to check for this at the end of urls. can you swap to that and give it a test?
| // check if operator entered full domain instead of subdomain | ||
| if strings.Contains(subdomain, ".okta.com") { | ||
| domains := strings.Split(subdomain, ".") | ||
| // i don't think sub-subdomains are legal for okta, but i could be wrong |
There was a problem hiding this comment.
also before we merge to master can you delete this and if it represents more code/testing we need to do, create a ticket that references this line?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the operator enters a full okta domain for the okta provider subdomain, we now truncate and accept the subdomain