Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Bump minimum supported PG version #259

Merged
merged 1 commit into from
Sep 9, 2024
Merged

README: Bump minimum supported PG version #259

merged 1 commit into from
Sep 9, 2024

Conversation

df7cb
Copy link
Contributor

@df7cb df7cb commented Jul 15, 2024

PG10 fails now:

ogr_fdw.c:1122:18: error: ‘BOOLARRAYOID’ undeclared ... and other errors

@df7cb
README: Bump minimum supported PG version
4177d16 
PG10 fails now:

ogr_fdw.c:1122:18: error: ‘BOOLARRAYOID’ undeclared
... and other errors
@df7cb
Copy link
Contributor Author

df7cb commented Jul 15, 2024

Full error log:

12:12:15 ### PostgreSQL 10 build ###
12:12:15 make[2]: Entering directory '/<<PKGBUILDDIR>>/build-10'
12:12:15 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fno-omit-frame-pointer -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fPIC -I/usr/include/gdal -I. -I/<<PKGBUILDDIR>> -I/usr/include/postgresql/10/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/mit-krb5  -c -o ogr_fdw.o /<<PKGBUILDDIR>>/ogr_fdw.c
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c: In function ‘pgCanConvertToOgr’:
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1122:18: error: ‘BOOLARRAYOID’ undeclared (first use in this function); did you mean ‘OIDARRAYOID’?
12:12:16  1122 |                 {BOOLARRAYOID, OFTIntegerList}, /* 1000 */
12:12:16       |                  ^~~~~~~~~~~~
12:12:16       |                  OIDARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1122:18: note: each undeclared identifier is reported only once for each function it appears in
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1123:18: error: ‘CHARARRAYOID’ undeclared (first use in this function); did you mean ‘TEXTARRAYOID’?
12:12:16  1123 |                 {CHARARRAYOID, OFTStringList}, /* 1002 */
12:12:16       |                  ^~~~~~~~~~~~
12:12:16       |                  TEXTARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1124:18: error: ‘NAMEARRAYOID’ undeclared (first use in this function); did you mean ‘ANYARRAYOID’?
12:12:16  1124 |                 {NAMEARRAYOID, OFTStringList}, /* 1003 */
12:12:16       |                  ^~~~~~~~~~~~
12:12:16       |                  ANYARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1128:18: error: ‘VARCHARARRAYOID’ undeclared (first use in this function); did you mean ‘VARCHAROID’?
12:12:16  1128 |                 {VARCHARARRAYOID, OFTStringList}, /* 1015 */
12:12:16       |                  ^~~~~~~~~~~~~~~
12:12:16       |                  VARCHAROID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1130:18: error: ‘INT8ARRAYOID’ undeclared (first use in this function); did you mean ‘INT4ARRAYOID’?
12:12:16  1130 |                 {INT8ARRAYOID, OFTInteger64List}, /* 1016 */
12:12:16       |                  ^~~~~~~~~~~~
12:12:16       |                  INT4ARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1133:18: error: ‘FLOAT8ARRAYOID’ undeclared (first use in this function); did you mean ‘FLOAT4ARRAYOID’?
12:12:16  1133 |                 {FLOAT8ARRAYOID, OFTRealList}, /* 1022 */
12:12:16       |                  ^~~~~~~~~~~~~~
12:12:16       |                  FLOAT4ARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c: In function ‘ogrCanConvertToPg’:
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1188:37: error: ‘INT8ARRAYOID’ undeclared (first use in this function); did you mean ‘INT4ARRAYOID’?
12:12:16  1188 |                 {OFTInteger64List, {INT8ARRAYOID, FLOAT8ARRAYOID, TEXTARRAYOID, VARCHARARRAYOID, 0}},
12:12:16       |                                     ^~~~~~~~~~~~
12:12:16       |                                     INT4ARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1188:51: error: ‘FLOAT8ARRAYOID’ undeclared (first use in this function); did you mean ‘FLOAT4ARRAYOID’?
12:12:16  1188 |                 {OFTInteger64List, {INT8ARRAYOID, FLOAT8ARRAYOID, TEXTARRAYOID, VARCHARARRAYOID, 0}},
12:12:16       |                                                   ^~~~~~~~~~~~~~
12:12:16       |                                                   FLOAT4ARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1188:81: error: ‘VARCHARARRAYOID’ undeclared (first use in this function); did you mean ‘VARCHAROID’?
12:12:16  1188 |                 {OFTInteger64List, {INT8ARRAYOID, FLOAT8ARRAYOID, TEXTARRAYOID, VARCHARARRAYOID, 0}},
12:12:16       |                                                                                 ^~~~~~~~~~~~~~~
12:12:16       |                                                                                 VARCHAROID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1191:65: error: ‘NAMEARRAYOID’ undeclared (first use in this function); did you mean ‘ANYARRAYOID’?
12:12:16  1191 |                 {OFTStringList, {TEXTARRAYOID, VARCHARARRAYOID, NAMEARRAYOID, CHARARRAYOID, 0}},
12:12:16       |                                                                 ^~~~~~~~~~~~
12:12:16       |                                                                 ANYARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1191:79: error: ‘CHARARRAYOID’ undeclared (first use in this function); did you mean ‘TEXTARRAYOID’?
12:12:16  1191 |                 {OFTStringList, {TEXTARRAYOID, VARCHARARRAYOID, NAMEARRAYOID, CHARARRAYOID, 0}},
12:12:16       |                                                                               ^~~~~~~~~~~~
12:12:16       |                                                                               TEXTARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1192:35: error: ‘BOOLARRAYOID’ undeclared (first use in this function); did you mean ‘OIDARRAYOID’?
12:12:16  1192 |                 {OFTIntegerList, {BOOLARRAYOID, INT2ARRAYOID, INT4ARRAYOID, INT8ARRAYOID, TEXTARRAYOID, VARCHARARRAYOID, 0}},
12:12:16       |                                   ^~~~~~~~~~~~
12:12:16       |                                   OIDARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c: In function ‘ogrReadColumnData’:
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1414:69: warning: passing argument 3 of ‘getTypeOutputInfo’ from incompatible pointer type [-Wincompatible-pointer-types]
12:12:16  1414 |                 getTypeOutputInfo(col.pgelmtype, &col.pgoutputfunc, &col.pgoutputvarlena);
12:12:16       |                                                                     ^~~~~~~~~~~~~~~~~~~~
12:12:16       |                                                                     |
12:12:16       |                                                                     _Bool *
12:12:16 In file included from /<<PKGBUILDDIR>>/ogr_fdw.h:52,
12:12:16                  from /<<PKGBUILDDIR>>/ogr_fdw.c:40:
12:12:16 /usr/include/postgresql/10/server/utils/lsyscache.h:164:63: note: expected ‘bool *’ {aka ‘char *’} but argument is of type ‘_Bool *’
12:12:16   164 | extern void getTypeOutputInfo(Oid type, Oid *typOutput, bool *typIsVarlena);
12:12:16       |                                                         ~~~~~~^~~~~~~~~~~~
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1415:73: warning: passing argument 3 of ‘getTypeBinaryOutputInfo’ from incompatible pointer type [-Wincompatible-pointer-types]
12:12:16  1415 |                 getTypeBinaryOutputInfo(col.pgelmtype, &col.pgsendfunc, &col.pgsendvarlena);
12:12:16       |                                                                         ^~~~~~~~~~~~~~~~~~
12:12:16       |                                                                         |
12:12:16       |                                                                         _Bool *
12:12:16 /usr/include/postgresql/10/server/utils/lsyscache.h:166:67: note: expected ‘bool *’ {aka ‘char *’} but argument is of type ‘_Bool *’
12:12:16   166 | extern void getTypeBinaryOutputInfo(Oid type, Oid *typSend, bool *typIsVarlena);
12:12:16       |                                                             ~~~~~~^~~~~~~~~~~~
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c: In function ‘ogrFeatureToSlot’:
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:1721:23: warning: initialization of ‘_Bool *’ from incompatible pointer type ‘bool *’ {aka ‘char *’} [-Wincompatible-pointer-types]
12:12:16  1721 |         bool* nulls = slot->tts_isnull;
12:12:16       |                       ^~~~
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c: In function ‘ogrSlotToFeature’:
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:2138:23: warning: initialization of ‘_Bool *’ from incompatible pointer type ‘bool *’ {aka ‘char *’} [-Wincompatible-pointer-types]
12:12:16  2138 |         bool* nulls = slot->tts_isnull;
12:12:16       |                       ^~~~
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:2383:30: error: ‘BOOLARRAYOID’ undeclared (first use in this function); did you mean ‘OIDARRAYOID’?
12:12:16  2383 |                         case BOOLARRAYOID:
12:12:16       |                              ^~~~~~~~~~~~
12:12:16       |                              OIDARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:2394:63: warning: passing argument 3 of ‘array_iterate’ from incompatible pointer type [-Wincompatible-pointer-types]
12:12:16  2394 |                                 while (array_iterate(it,  &d, &isnull))
12:12:16       |                                                               ^~~~~~~
12:12:16       |                                                               |
12:12:16       |                                                               _Bool *
12:12:16 In file included from /usr/include/postgresql/10/server/utils/acl.h:38,
12:12:16                  from /usr/include/postgresql/10/server/catalog/objectaddress.h:18,
12:12:16                  from /usr/include/postgresql/10/server/commands/defrem.h:17,
12:12:16                  from /<<PKGBUILDDIR>>/ogr_fdw.h:34:
12:12:16 /usr/include/postgresql/10/server/utils/array.h:426:71: note: expected ‘bool *’ {aka ‘char *’} but argument is of type ‘_Bool *’
12:12:16   426 | extern bool array_iterate(ArrayIterator iterator, Datum *value, bool *isnull);
12:12:16       |                                                                 ~~~~~~^~~~~~
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:2404:30: error: ‘CHARARRAYOID’ undeclared (first use in this function); did you mean ‘TEXTARRAYOID’?
12:12:16  2404 |                         case CHARARRAYOID:
12:12:16       |                              ^~~~~~~~~~~~
12:12:16       |                              TEXTARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:2405:30: error: ‘NAMEARRAYOID’ undeclared (first use in this function); did you mean ‘ANYARRAYOID’?
12:12:16  2405 |                         case NAMEARRAYOID:
12:12:16       |                              ^~~~~~~~~~~~
12:12:16       |                              ANYARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:2407:30: error: ‘VARCHARARRAYOID’ undeclared (first use in this function); did you mean ‘VARCHAROID’?
12:12:16  2407 |                         case VARCHARARRAYOID:
12:12:16       |                              ^~~~~~~~~~~~~~~
12:12:16       |                              VARCHAROID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:2414:62: warning: passing argument 3 of ‘array_iterate’ from incompatible pointer type [-Wincompatible-pointer-types]
12:12:16  2414 |                                 while (array_iterate(it, &d, &isnull))
12:12:16       |                                                              ^~~~~~~
12:12:16       |                                                              |
12:12:16       |                                                              _Bool *
12:12:16 /usr/include/postgresql/10/server/utils/array.h:426:71: note: expected ‘bool *’ {aka ‘char *’} but argument is of type ‘_Bool *’
12:12:16   426 | extern bool array_iterate(ArrayIterator iterator, Datum *value, bool *isnull);
12:12:16       |                                                                 ~~~~~~^~~~~~
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:2428:30: error: ‘FLOAT8ARRAYOID’ undeclared (first use in this function); did you mean ‘FLOAT4ARRAYOID’?
12:12:16  2428 |                         case FLOAT8ARRAYOID:
12:12:16       |                              ^~~~~~~~~~~~~~
12:12:16       |                              FLOAT4ARRAYOID
12:12:16 /<<PKGBUILDDIR>>/ogr_fdw.c:2437:63: warning: passing argument 3 of ‘array_iterate’ from incompatible pointer type [-Wincompatible-pointer-types]
12:12:16  2437 |                                 while (array_iterate(it,  &d, &isnull))
12:12:16       |                                                               ^~~~~~~
12:12:16       |                                                               |
12:12:16       |                                                               _Bool *
12:12:16 /usr/include/postgresql/10/server/utils/array.h:426:71: note: expected ‘bool *’ {aka ‘char *’} but argument is of type ‘_Bool *’
12:12:16   426 | extern bool array_iterate(ArrayIterator iterator, Datum *value, bool *isnull);
12:12:16       |                                                                 ~~~~~~^~~~~~
12:12:16 make[2]: *** [<builtin>: ogr_fdw.o] Error 1
12:12:16 make[2]: Leaving directory '/<<PKGBUILDDIR>>/build-10'
12:12:16 ### End 10 build (FAILED with exit code 2) ###

https://pgdgbuild.dus.dg-i.net/job/pgsql-ogr-fdw-binaries/86/architecture=amd64,distribution=sid/console

@df7cb
Copy link
Contributor Author

df7cb commented Jul 15, 2024

On a side note, PG 11/12 still test fine, perhaps add them to .github/workflows/ci.yml ? You can easily drop them again if the tests start failing.

@pramsey pramsey merged commit 22fcef1 into pramsey:master Sep 9, 2024
5 checks passed
pramsey added a commit that referenced this pull request Sep 9, 2024
@pramsey
Add CI for pg12/13 per #259
2ba5f72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@df7cb @pramsey