Issue 23: add integration test #20
Conversation
ravibeta
force-pushed
the
integration-tests
branch
from
30897c4 to
f7bb781
Compare
Codecov Report
@@ Coverage Diff @@
## feature-separate-adapters #20 +/- ##
===============================================================
+ Coverage 72.77% 74.51% +1.73%
- Complexity 95 101 +6
===============================================================
Files 10 10
Lines 518 518
Branches 47 47
===============================================================
+ Hits 377 386 +9
+ Misses 102 95 -7
+ Partials 39 37 -2
Continue to review full report at Codecov.
|
test/integration/src/main/java/io/pravega/test/integration/BookKeeperIntegrationTestBase.java
Outdated
Show resolved
Hide resolved
test/integration/src/main/java/io/pravega/test/integration/HDFSIntegrationTest.java
Outdated
Show resolved
Hide resolved
test/integration/src/test/resources/controller.config.properties
Outdated
Show resolved
Hide resolved
ravibeta
force-pushed
the
integration-tests
branch
from
a4dac7c to
74d386b
Compare
|
Please create an issue and reference it in this PR's title and description. |
|
Also, please remove the 2 JAR files you committed. |
|
Yes Andrei |
| } | ||
|
|
||
| //endregion | ||
| } |
There was a problem hiding this comment.
The libs does not appear in the branch. It only appears in the review. This is weird.
Ok i added the files back in the libs and they disappeared from the review.
Then I deleted the files one more time from the libs and they reappeared in the review.
Looks like the review wants to show that these files are deleted but there is an option to hide deleted files from the view by clicking on settings.
Signed-off-by: Ravi Rajamani <ravi.rajamani@emc.com>
ravibeta
force-pushed
the
integration-tests
branch
from
f6bc5ce to
1afc5e8
Compare
Signed-off-by: Ravi Rajamani <ravi.rajamani@emc.com>
Signed-off-by: Ravi Rajamani <ravi.rajamani@emc.com>
| } | ||
|
|
||
| //endregion | ||
| } |
Signed-off-by: Ravi Rajamani <ravi.rajamani@emc.com>
Change log description
This repository produces bindings which is used in container deployments using docker images. This change adds and tries out the integration tests.
Purpose of the change
It uses the jars produced by this repository and runs integration tests against it.
What the code does
Fixes: #23
Initially, all the integration tests were moved to see if the new jars can pass the tests. The resulting build proved that they did:
https://travis-ci.com/github/ravibeta/pravega-storage-adapters-1/builds/182858340
Initially all the system tests were moved. They all passed. There were two tests that were marked as ignored because of the difference in the version checked into the libs but they pass when all the dependencies are of the same version. This PR has now been modified to only include those pertaining to hdfs. It does not include extendeds3 yet because that is pending another pr which is already out for review. I did try a dry run with extendeds3 to see if there are any changes in dependencies and there were none.
How to verify it
We need a working pravega build and the jars from this repository to run the tests. Ideally, there will be no bindings in the Pravega build other than filesystem.