refactor: Lazy load algolia docsearch #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
reviewed
Dec 4, 2024
rschristian
force-pushed
the
refactor/lazy-load-algolia
branch
from
79bb3e2 to
81f4d83
Compare
rschristian
commented
Dec 6, 2024
rschristian
force-pushed
the
refactor/lazy-load-algolia
branch
from
c2966cf to
5a4c900
Compare
JoviDeCroock
approved these changes
Dec 6, 2024
rschristian
force-pushed
the
refactor/lazy-load-algolia
branch
from
5a4c900 to
36c0d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1106, it looks like I was doubting the value of lazy loading this. Certainly possible I was wrong to do so though.