Ogury: port new adapter from Go #3788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxPhoenix
changed the title
CTMBNara
requested changes
Mar 4, 2025
Comment on lines
61
to
64
| if (request == null || CollectionUtils.isEmpty(request.getImp())) { | ||
| errors.add(BidderError.badInput("There are no valid impressions to create bid request to ogury bidder")); | ||
| return Result.withErrors(errors); | ||
| } |
Comment on lines
115
to
133
| private List<Imp> modifyImps(BidRequest request, Consumer<Imp> impWithOguryParamsHandler) { | ||
| return Optional.of(request) | ||
| .map(BidRequest::getImp) | ||
| .map(sourceImps -> sourceImps.stream().map(imp -> { | ||
| final ObjectNode impExt = resolveImpExt(imp); | ||
| final ObjectNode impExtBidderHoist = resolveImpExtBidderHoist(impExt); | ||
|
|
||
| final ObjectNode modifiedImpExt = modifyImpExt(impExt, impExtBidderHoist); | ||
| final BigDecimal bidFloor = resolveBidFloor(request, imp); | ||
| final Imp modifiedImp = modifyImp(imp, bidFloor, modifiedImpExt); | ||
|
|
||
| if (hasOguryParams(impExtBidderHoist)) { | ||
| impWithOguryParamsHandler.accept(modifiedImp); | ||
| } | ||
|
|
||
| return modifiedImp; | ||
| })) | ||
| .map(Stream::toList).orElse(null); | ||
| } |
There was a problem hiding this comment.
Please, see examples how to iterate over imps in other adapters
See https://github.com/prebid/prebid-server-java/pull/3768/files as a starting point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
New Ogury adapter (Port PR from PBS-Go)
#3700
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
Unit tests with decent coverage
🏎 Quality check