-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: resolve maven conflicts between core and bundle #3793
base: master
Are you sure you want to change the base?
Conversation
The google-cloud-storage dependency creates conflicts on Maven dependencies, causing a mismatch between the core and bundle versions in all builds. @EvgeniiMunin will this change be okay for you? |
Excluding |
<exclusions> | ||
<exclusion> | ||
<artifactId>failureaccess</artifactId> | ||
<groupId>com.google.guava</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please swap groupId
and artifactId
. There is an unspoken convention that groupId should go before artifactId.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And while we're at it, it might be worth bumping dependencies for this module. Google cloud is being updated quite frequently, and we're already several versions behind.
3ef0ac3
to
f3a843c
Compare
# Conflicts: # extra/modules/greenbids-real-time-data/pom.xml
ffab070
to
367618a
Compare
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check