Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy Sandbox: support testing label header #3381

Merged
merged 32 commits into from
Mar 5, 2024
Merged

Privacy Sandbox: support testing label header #3381

merged 32 commits into from
Mar 5, 2024

Conversation

pm-nilesh-chate
Copy link
Contributor

@pm-nilesh-chate pm-nilesh-chate commented Jan 3, 2024 •
edited by SyntaxNode
Loading

Implements #3297

@pm-nilesh-chate pm-nilesh-chate mentioned this pull request Jan 3, 2024
Closed
@bsardo bsardo self-assigned this Jan 12, 2024
@SyntaxNode SyntaxNode self-assigned this Jan 16, 2024
@pm-nilesh-chate pm-nilesh-chate marked this pull request as ready for review January 19, 2024 08:29
SyntaxNode
SyntaxNode reviewed Jan 19, 2024
View reviewed changes
config/account.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
endpoints/cookie_sync.go Outdated Show resolved Hide resolved
endpoints/cookie_sync.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction_test.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
usersync/chooser.go Outdated Show resolved Hide resolved
@bsardo bsardo changed the title Privacy Sandbox: support testing label header #3297 Privacy Sandbox: support testing label header Jan 24, 2024
bsardo
bsardo reviewed Jan 25, 2024
View reviewed changes
endpoints/cookie_sync.go Outdated Show resolved Hide resolved
endpoints/cookie_sync.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
bsardo
bsardo reviewed Feb 1, 2024
View reviewed changes
openrtb_ext/request_wrapper.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
endpoints/cookie_sync.go Outdated Show resolved Hide resolved
endpoints/openrtb2/sample-requests/valid-whole/supplementary/site.json Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/amp_auction.go Outdated Show resolved Hide resolved
bsardo
bsardo reviewed Feb 15, 2024
View reviewed changes
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/amp_auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/video_auction.go Outdated Show resolved Hide resolved
endpoints/cookie_sync_test.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction_test.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction_test.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction_test.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction_test.go Outdated Show resolved Hide resolved
SyntaxNode
SyntaxNode reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@SyntaxNode SyntaxNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few comments...

endpoints/cookie_sync.go Outdated Show resolved Hide resolved
endpoints/cookie_sync.go Outdated Show resolved Hide resolved
endpoints/cookie_sync_test.go Outdated Show resolved Hide resolved
endpoints/cookie_sync_test.go Outdated Show resolved Hide resolved
endpoints/cookie_sync_test.go Outdated Show resolved Hide resolved
endpoints/cookie_sync_test.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
bsardo
bsardo reviewed Feb 26, 2024
View reviewed changes
endpoints/openrtb2/auction_test.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction_test.go Outdated Show resolved Hide resolved
endpoints/openrtb2/auction_test.go Show resolved Hide resolved
endpoints/cookie_sync_test.go Outdated Show resolved Hide resolved
endpoints/cookie_sync_test.go Outdated Show resolved Hide resolved
endpoints/openrtb2/amp_auction_test.go Outdated Show resolved Hide resolved
bsardo
bsardo previously approved these changes Feb 27, 2024
View reviewed changes
SyntaxNode
SyntaxNode reviewed Feb 27, 2024
View reviewed changes
config/account.go Show resolved Hide resolved
endpoints/cookie_sync.go Outdated Show resolved Hide resolved
endpoints/cookie_sync_test.go Show resolved Hide resolved
endpoints/openrtb2/auction.go Show resolved Hide resolved
endpoints/openrtb2/auction.go Show resolved Hide resolved
endpoints/openrtb2/auction.go Show resolved Hide resolved
endpoints/openrtb2/auction.go Outdated Show resolved Hide resolved
SyntaxNode
SyntaxNode approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@SyntaxNode SyntaxNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the main flow manually with Chrome 122 using the developer flags to enable and disable the testing label header.

@SyntaxNode SyntaxNode merged commit 4b1ca6b into prebid:master Mar 5, 2024
3 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsardo bsardo bsardo approved these changes

@SyntaxNode SyntaxNode SyntaxNode approved these changes

Assignees

@bsardo bsardo

@SyntaxNode SyntaxNode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm-nilesh-chate @bsardo @SyntaxNode