Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenX: Determine bid type from bid.mtype #4241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gmiedlar-ox
Copy link
Contributor

@gmiedlar-ox gmiedlar-ox commented Feb 27, 2025

OpenX started to return mtype field for bids in bid response, so now bid type can be determined based on this property in OpenX bidder adapter.
We want to determine bid type based on bid mtype from bid response, to be able to process multi-format requests.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8b7c575

openx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/openx/openx.go:35:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:76:	makeRequest		75.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:122:	preprocess		85.3%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:191:	MakeBids		87.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:247:	getBidVideo		100.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:258:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:278:	getMediaTypeForImp	88.9%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:294:	Builder			100.0%
total:								(statements)		88.0%

@bsardo bsardo changed the title EXCH-11681 Determine bid type based on bid.mtype OpenX: Determine bid type from bid.mtype Feb 27, 2025
@bsardo bsardo added the adapter label Feb 27, 2025
@gmiedlar-ox gmiedlar-ox reopened this Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8b7c575

openx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/openx/openx.go:35:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:76:	makeRequest		75.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:122:	preprocess		85.3%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:191:	MakeBids		87.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:247:	getBidVideo		100.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:258:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:278:	getMediaTypeForImp	88.9%
github.com/prebid/prebid-server/v3/adapters/openx/openx.go:294:	Builder			100.0%
total:								(statements)		88.0%

@bsardo
Copy link
Collaborator

bsardo commented Mar 6, 2025

@pm-shriprasad-marathe can you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants