-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adagio: update bidder adapter documentation #6327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4e2836d to
cf4c3a4
Compare
c9ac56b to
c8772c4
Compare
c8772c4 to
4798ba8
Compare
|
Hi @muuki88, |
muuki88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
Will do. I forgot to post the comments. 🙈
dev-docs/bidders/adagio.md
Outdated
| gpp_supported: true | ||
| coppa_supported: true | ||
| gpp_supported: true | ||
| gpp_sids: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's impossible that you ensure all gpp_sids 😉
Please add the concrete ones you support
https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter
Possible values
tcfeu, tcfca, usnat, usstate_all, usp
dev-docs/bidders/adagio.md
Outdated
| usp_supported: true | ||
| gpp_supported: true | ||
| coppa_supported: true | ||
| gpp_supported: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| gpp_supported: true |
deprecated and not needed. the gpp_sids meta field is enough
| * First Party Data takes precedence over AdUnit-level parameters. | ||
| * If the FPD value is an array, the first value will be used. | ||
|
|
||
| <a id="prebid-server-adapter"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <a id="prebid-server-adapter"></a> |
jekyll generates id="..." attributes automatically from the header. In this case it should be prebid-server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it because #prebid-server already exists on the page. It is the id of Prebid Server entry in the left side menu.
And I would like to keep my TOC.
|
|
||
| **Example for EMEA** | ||
|
|
||
| {% raw %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the raw around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of
Liquid Warning: Liquid syntax error (line 103): [:dot, "."] is not a valid expression in "{{.GDPR}}" in dev-docs/bidders/adagio.md
Liquid Warning: Liquid syntax error (line 103): [:dot, "."] is not a valid expression in "{{.GDPRConsent}}" in dev-docs/bidders/adagio.md
Liquid Warning: Liquid syntax error (line 103): [:dot, "."] is not a valid expression in "{{.USPrivacy}}" in dev-docs/bidders/adagio.md
...
🏷 Type of documentation
📋 Checklist
N/A
The PR aims to improve readability and align prebid.js / prebid-server adapters