Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added list of exported metrics #207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added list of exported metrics #207

wants to merge 1 commit into from

Conversation

noyoshi
Copy link
Collaborator

@noyoshi noyoshi commented Jan 24, 2024

Added a list of the exported metrics to the readme.

Further info would be nice to add to the table - such as the metric type and the description.

@noyoshi noyoshi requested a review from tgaddair January 24, 2024 22:01
@@ -163,13 +162,56 @@ print("Response:", resp[0].choices[0].message.content)

See [OpenAI Compatible API](https://predibase.github.io/lorax/guides/openai_api) for details.

### Metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to docs instead? We have a section called Reference, we could add a page called Prometheus Metrics or similar.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is this something we can expose via the openapi.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants