fix: create a GUI application on Windows, not Console #2067
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an empty console to be opened when we launch this program from Windows Explorer.
certik
added a commit
to certik/pixi
that referenced
this pull request
Sep 17, 2024
This makes `std::cout` working again after switching to a GUI application in prefix-dev#2067. It still does not open a console when launched from the Windows Explorer, but when launched from a terminal, it will now print to the terminal again, as before.
certik
changed the title
|
I tested on Windows natively (in a |
baszalmstra
approved these changes
Sep 18, 2024
baszalmstra
approved these changes
Sep 18, 2024
|
Thanks @certik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an empty console to be opened when we launch this program from Windows Explorer.
Note that this change makes
std::coutnot work anymore (if launched from a console). This is fixed in a separate PR: #2070.