feat: add-pre-commit

.gitattributes

@@ -1,3 +1,2 @@
 # GitHub syntax highlighting
 pixi.lock linguist-language=YAML
-

.github/workflows/build.yml

@@ -8,22 +8,15 @@ jobs:
 
     steps:
         - uses: actions/checkout@v4
-        
+
         - uses: prefix-dev/setup-pixi@v0.5.1
           with:
             pixi-version: "latest"
 
         - name: pixi install
-          run: | 
+          run: |
            pixi install
 
-        - name: format
-          run: pixi run fmt-check
-
-        - name: lint
-          run: pixi run lint-check
-
         - name: run tests
-          run: | 
+          run: |
            pixi run -e test pytest
-

.github/workflows/pre-commit.yml

@@ -0,0 +1,21 @@
+name: pre-commit
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up pixi
+        uses: prefix-dev/setup-pixi@v0.8.1
+        with:
+          environments: lint
+      - name: pre-commit
+        run: pixi run pre-commit-run --color=always --show-diff-on-failure
+        env:
+          # As the rust GitHub action is better at the rust jobs it can be skipped in this job.
+          SKIP: fmt

.pre-commit-config.yaml

@@ -0,0 +1,48 @@
+exclude: (^.pixi/|.snap)
+repos:
+  - repo: local
+    hooks:
+      - id: pixi-install
+        name: pixi-install
+        entry: pixi install -e lint
+        language: system
+        always_run: true
+        require_serial: true
+        pass_filenames: false
+      # pre-commit-hooks
+      - id: check-yaml
+        name: check-yaml
+        entry: pixi run -e lint check-yaml
+        language: system
+        types: [yaml]
+      - id: end-of-file
+        name: end-of-file
+        entry: pixi run -e lint end-of-file-fixer
+        language: system
+        types: [text]
+        stages: [commit, push, manual]
+      - id: trailing-whitespace
+        name: trailing-whitespace
+        entry: pixi run -e lint trailing-whitespace-fixer
+        language: system
+        types: [text]
+        stages: [commit, push, manual]
+      # Use ruff for python examples
+      - id: ruff
+        name: ruff
+        entry: pixi run -e lint ruff check --fix --exit-non-zero-on-fix --force-exclude
+        language: system
+        types_or: [python, pyi]
+        require_serial: true
+      - id: ruff-format
+        name: ruff-format
+        entry: pixi run -e lint ruff format --force-exclude
+        language: system
+        types_or: [python, pyi]
+        require_serial: true
+      # typos
+      - id: typos
+        name: typos
+        entry: pixi run -e lint typos --write-changes --force-exclude
+        language: system
+        types: [text]

LICENSE.txt

@@ -25,4 +25,4 @@ DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
 SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
 OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

README.md

@@ -1,4 +1,4 @@
-# Compatability tools for Rattler Build
+# Compatibility tools for Rattler Build
 
 This repository contains a set of tools to help with the integration of rattler-build into conda-forge.
 Mainly by providing an interface that is recognizable for uses used to `conda-build`

pixi.toml

@@ -32,10 +32,19 @@ ruff = "*"
 [feature.test.tasks]
 test = "pytest"
 snapshot_update = "pytest --snapshot-update"
-lint = "ruff check src"
-lint-check = "ruff check --check --diff src"
-fmt = "ruff format src tests"
-fmt-check = "ruff format --check --diff src tests"
+
+
+[feature.lint.dependencies]
+pre-commit = ">=3.7.1,<4"
+pre-commit-hooks = ">=4.6.0,<5"
+ruff = ">=0.4.8,<0.5"
+typos = ">=1.23.1,<2"
+
+[feature.lint.tasks]
+pre-commit-install = "pre-commit-install"
+pre-commit-run = "pre-commit run"
+
 
 [environments]
 test = ["test"]
+lint = { features = ["lint"], no-default-feature = true, solve-group = "default" }

src/rattler_build_conda_compat/lint.py

@@ -300,8 +300,8 @@ def lint_non_noarch_dont_constrain_python_and_rbase(requirements_section):
         for reqs in [filtered_host_reqs, filtered_run_reqs]:
             if language not in reqs:
                 for req in reqs:
-                    splitted = req.split(" ", 1)
-                    if len(splitted) > 1:
+                    split = req.split(" ", 1)
+                    if len(split) > 1:
                         constraint = req.split(" ", 1)[1]
                         if constraint.startswith(">") or constraint.startswith("<"):
                             lints.append(

tests/data/recipe_requirements.yaml

@@ -5,4 +5,4 @@ requirements:
       then:
         - ${{ cdt('xorg-x11-proto-devel') }}
   host:
-    - python
+    - python