Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove self type #20

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Jul 18, 2024

Remove Self type because its not available for python 3.8.

Bumps to 3.10 and adds typing-extensions.

Fixes #19

Copy link
Collaborator

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the one nitpick.

Unrelated: would it make sense to move the content of pixi.toml into pyproject.toml?
Then we could remove some duplication.

pixi.toml Outdated Show resolved Hide resolved
@tdejager
Copy link
Collaborator

tdejager commented Jul 18, 2024

Looks good, apart from the one nitpick.

Unrelated: would it make sense to move the content of pixi.toml into pyproject.toml? Then we could remove some duplication.

We could, the only downside is that if you edit the pyproject.toml it is rebuilt, when running a pixi install.

@tdejager tdejager merged commit ae3aeab into prefix-dev:main Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package incompatible with Python < 3.11 but declares Python >= 3.8
3 participants