Skip to content

Conversation

@scunningham
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request moves the eval package from internal/pkg/eval to pkg/eval, making it available as an exported package for external use. The PR title mentions this is needed for use in "cre" (likely referring to an external consumer).

Changes:

  • Moved eval package from internal to public API surface
  • Updated all import references from internal/pkg/eval to pkg/eval
  • Added defensive nil check for config parameter in the exported Detect function

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/preq_test.go Updated import path to use the new exported eval package
cmd/wasm/wasm.go Updated import path to use the new exported eval package
pkg/eval/eval.go Added nil check for config parameter to make the exported API more robust

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@scunningham scunningham merged commit 99a8dd2 into main Jan 13, 2026
8 checks passed
@scunningham scunningham deleted the revert_eval branch January 13, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants