Disregard versioning metadata when calculating rule hash.

[scunningham]

No description provided.

[Copilot]

Pull Request Overview

This PR refactors the HashRule function to ignore non-semantic metadata (version, generation counter, and existing hash) when computing the rule’s hash, ensuring a stable identifier across metadata-only changes.

• Changed HashRule signature to accept a ParseRuleT and removed the old any version.
• Zeroes out Metadata.Gen, Metadata.Version, and Metadata.Hash before marshaling.
• Marshals the cleaned rule object for deterministic hashing.

Comments suppressed due to low confidence (2)

pkg/parser/tree.go:709

• Consider adding unit tests to verify that changes to Gen, Version, and Hash metadata do not affect the computed rule hash.

rule.Metadata.Gen = 0      // Gen is bumped on every semantic change, so we don't want it in the hash

pkg/parser/tree.go:707

• Modifying the rule parameter in-place may lead to unintended side-effects if ParseRuleT contains reference types; consider deep copying or documenting this assumption.

// NOTE: Modify 'rule' is acceptable because parameter passed by value.