Separate hash from stable hash. #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR splits the existing HashRule behavior into two distinct functions—HashRule (for general identity hashing) and StableHash (for version-agnostic hashing)—and centralizes the actual SHA-256 + base58 logic in a new helper _hashRule.
- Introduce
StableHashto exclude version/gen metadata when hashing. - Refactor
HashRuleto delegate to_hashRuleafter clearing previous hash. - Add
_hashRuleas a private helper for consistent JSON marshaling and hashing.
Comments suppressed due to low confidence (1)
pkg/parser/tree.go:720
- [nitpick] In Go, leading underscores in function names are uncommon. Consider renaming
_hashRuletohashRuleto follow Go naming conventions for unexported functions.
func _hashRule(rule ParseRuleT) (string, error) {
| // HashRule to provide a unique stable identity for the rule. It can be used for dupe detection. | ||
| // The hash is based on the rule's content, excluding metadata that is not semantically important. | ||
| // HashRule to provide a unique identity for the rule. | ||
| // The hash is based on the rule's content, excluding previous hash calculations. |
There was a problem hiding this comment.
[nitpick] The phrase "excluding previous hash calculations" can be clearer; consider specifying "excluding the existing rule.Metadata.Hash field" so readers understand exactly which metadata is omitted.
tonymeehan
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.