You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is the current behavior?
When a document is modified in such a way that a listener gets a document update, the dispatched DOCUMENT_MODIFIED action updates the ordered array to have an undefined id. This does not occur when a document update does not affect the order of the ordered result.
What is the expected behavior?
Document updates should still return id after updating ordered result in redux
Which version of redux-firestore are you using? What about other dependencies?
"redux-firestore": "^0.13.0"
"react-redux-firebase": "^3.6.0"
"firebase": "^7.15.5"
Which environments/browsers are affected by this issue? Did this work in previous versions or setups?
Have tested on Safari, Firefox and Chrome in OS X development environment. Have not seen in previous versions or setups.
Minimal demo to reproduce issue (using codesandbox or similar)
Have ordered listener with storeAs value and modify a document such that the order would change. Once DOCUMENT_MODIFIED action dispatches the modified document no longer includes an id in ordered result in redux.
The first return statement of the modifyDoc function in reducers/orderedReducer.js is returning the action.payload.data without an id. We implemented a patch-package that spreads the action.meta.doc with action.payload.data in the newArrayWithItemMoved call that resolved the issue for us.
The text was updated successfully, but these errors were encountered:
What is the current behavior?
When a document is modified in such a way that a listener gets a document update, the dispatched DOCUMENT_MODIFIED action updates the ordered array to have an undefined id. This does not occur when a document update does not affect the order of the ordered result.
What is the expected behavior?
Document updates should still return id after updating ordered result in redux
Which version of redux-firestore are you using? What about other dependencies?
"redux-firestore": "^0.13.0"
"react-redux-firebase": "^3.6.0"
"firebase": "^7.15.5"
Which environments/browsers are affected by this issue? Did this work in previous versions or setups?
Have tested on Safari, Firefox and Chrome in OS X development environment. Have not seen in previous versions or setups.
Minimal demo to reproduce issue (using codesandbox or similar)
Have ordered listener with storeAs value and modify a document such that the order would change. Once DOCUMENT_MODIFIED action dispatches the modified document no longer includes an id in ordered result in redux.
The first return statement of the modifyDoc function in reducers/orderedReducer.js is returning the action.payload.data without an id. We implemented a patch-package that spreads the action.meta.doc with action.payload.data in the newArrayWithItemMoved call that resolved the issue for us.
The text was updated successfully, but these errors were encountered: