fix: preserve id on DOCUMENT_MODIFIED reordering #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 90.09% 90.11% +0.01%
==========================================
Files 19 19
Lines 626 627 +1
==========================================
+ Hits 564 565 +1
Misses 62 62
Continue to review full report at Codecov.
|
|
@prescottprue Is there anything else you'd like to see in order to get this minor bug fix merged? |
prescottprue
added a commit
that referenced
this pull request
Sep 30, 2020
* fix: preserve id on document modified reordering (#308) - @puppybits * fix(types): de-dupe action types by reusing existing const (#290) - @msutkowski * fix(docs): enhanced example in README (#286) - @gregfenton * build(deps): update lodash to 4.17.20 * build(deps): bump elliptic from 6.5.2 to 6.5.3 (#302) * build(deps): bump elliptic from 6.5.1 to 6.5.3 in /examples/basic (#301) * build(deps): bump http-proxy from 1.18.0 to 1.18.1 in /examples/basic (#306) * build(deps): bump handlebars from 4.5.1 to 4.7.6 in /examples/basic (#305) * build(deps-dev): bump codecov from 3.6.5 to 3.7.1 (#300) Co-authored-by: Bobby <bobby@getfiskal.com> Co-authored-by: gregfenton <greg.fenton@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a DOCUMENT_MODIFIED && newIndex !== oldIndex the
idof the ordered document is removed. This fix ensures that the meta.doc is spread into the newly changed document.Check List
If not relevant to pull request, check off as complete
Relevant Issues
#292