Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add permissions hook #229

Merged
merged 5 commits into from
Jan 15, 2025
Merged

feat: add permissions hook #229

merged 5 commits into from
Jan 15, 2025

Conversation

richard015ar
Copy link
Contributor

@richard015ar richard015ar commented Jan 15, 2025

See: https://github.com/pressbooks/private/issues/1530#issuecomment-2591157358

This pull request includes changes to the get_allowed_pages function in the src/Support/helpers.php file. The main update is to enhance the flexibility of the allowed pages by merging the existing pages with additional pages provided via a filter called pb_institutional_im_allowed_pages.

Usage example in https://github.com/pressbooks/pressbooks-tos/pull/10

Copy link
Contributor

@fdalcin fdalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changes work as expected locally.

@fdalcin fdalcin merged commit e5c548b into dev Jan 15, 2025
@fdalcin fdalcin deleted the feat/add-allowed-pages-hook branch January 15, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants