Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update header padding #446

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix: update header padding #446

merged 2 commits into from
Jan 15, 2025

Conversation

SteelWagstaff
Copy link
Member

@SteelWagstaff SteelWagstaff commented Jan 13, 2025 •
edited
Loading

Apply padding to .header__inside instead of .header to match Aldine. Fix for #445.

To test:

  1. Apply a background header color other than #FFF on the network in Appearance -> Customize
  2. Observe white padding in the header and footer
  3. Checkout this branch
  4. Observe the padding now appears with the background color applied.

fdalcin
fdalcin approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@fdalcin fdalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdalcin fdalcin merged commit db2572b into dev Jan 15, 2025
@fdalcin fdalcin deleted the fix/header-style branch January 15, 2025 17:11
@pressbooks-ops pressbooks-ops mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdalcin fdalcin fdalcin approved these changes

@cmurtagh cmurtagh Awaiting requested review from cmurtagh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteelWagstaff @fdalcin @actions-user